Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 1.20.6 #1338

Merged
merged 4 commits into from
Oct 12, 2024
Merged

support 1.20.6 #1338

merged 4 commits into from
Oct 12, 2024

Conversation

rom1504
Copy link
Member

@rom1504 rom1504 commented Oct 12, 2024

No description provided.

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

fyi @extremeheat

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

4) encodes chat packet once and send it to two clients

Using port for tests: 41897
Disconnecting client because error TypeError [ERR_INVALID_ARG_TYPE]: SizeOf error for undefined : The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received undefined
at new NodeError (node:internal/errors:405:5)
at Function.byteLength (node:buffer:779:11)
at Object.string (eval at compile (/home/runner/work/node-minecraft-protocol/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), :77:25)
at Object.packet_registry_data (eval at compile (/home/runner/work/node-minecraft-protocol/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), :1563:27)
at eval (eval at compile (/home/runner/work/node-minecraft-protocol/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), :1663:66)

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

feels like the error would come from some place where 1.20.5 is hard coded

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

we kind of need to skip 1.20.5 and go to .6 because of the fact they picked the same protocol version...

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

we're not writing packet_registry_data right

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

solved

@rom1504 rom1504 merged commit 0b0012d into master Oct 12, 2024
25 checks passed
@rom1504 rom1504 deleted the 1.20.6 branch October 12, 2024 23:08
@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant