Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verbose DataStats for metatensor #5905

Closed
wyli opened this issue Jan 26, 2023 · 0 comments · Fixed by #7814
Closed

verbose DataStats for metatensor #5905

wyli opened this issue Jan 26, 2023 · 0 comments · Fixed by #7814
Labels
Contribution wanted Feature request

Comments

@wyli
Copy link
Contributor

wyli commented Jan 26, 2023

Is your feature request related to a problem? Please describe.
the DataStats transform can print basic info about input tensors:

MONAI/monai/transforms/utility/array.py

Lines 681 to 684 in 59593bb

class DataStats(Transform):
"""
Utility transform to show the statistics of data for debug or analysis.
It can be inserted into any place of a transform chain and check results of previous transforms.

but it can't call the print_verbose, which makes it impossible to inspect metadata. would be great to make the metadata optionally printed.

MONAI/monai/data/meta_tensor.py

Lines 559 to 561 in 59593bb

def print_verbose(self) -> None:
"""Verbose print with meta data."""
print(self)

slicepaste added a commit to slicepaste/MONAI that referenced this issue May 30, 2024
@slicepaste
Fixes Project-MONAI#5905
80f9793 
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
@slicepaste slicepaste mentioned this issue May 30, 2024
Merged
7 tasks
@KumoLiu KumoLiu closed this as completed in 19cc6f0 Sep 4, 2024
hjmjohnson pushed a commit to hjmjohnson/MONAI that referenced this issue Sep 8, 2024
@slicepaste @pre-commit-ci
@KumoLiu @ericspod @surajpaib @atbenmurray @hjmjohnson
Make MetaTensor optional printed in DataStats and DataStatsd Project-…
55d9691 
…MONAI#5905 (Project-MONAI#7814)

Fixes Project-MONAI#5905 

### Description

We simply add one argument for DataStats and DataStatsd to make
MetaTensor optional printed.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Co-authored-by: Suraj Pai <b.pai@maastrichtuniversity.nl>
Co-authored-by: Ben Murray <ben.murray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contribution wanted Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make MetaTensor optional printed in DataStats and DataStatsd #5905 slicepaste/MONAI
1 participant
@wyli