Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MAISI networks to use monai core components #7988

Closed
guopengf opened this issue Aug 5, 2024 · 0 comments · Fixed by #7989, #7993 or #8005
Closed

Refactor MAISI networks to use monai core components #7988

guopengf opened this issue Aug 5, 2024 · 0 comments · Fixed by #7989, #7993 or #8005
Assignees
@guopengf

Comments

@guopengf
Copy link
Contributor

guopengf commented Aug 5, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

GenerativeModels is moved to monai core. We plan to refactor three MAISI networks, including AutoencoderKlMaisi, DiffusionModelUNetMaisi, and ControlNetMaisi and use monai core components.

Public
Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@guopengf guopengf self-assigned this Aug 5, 2024
@guopengf guopengf linked a pull request Aug 5, 2024 that will close this issue
Refactor DiffusionModelUNetMaisi #7989
Merged
7 tasks
@guopengf guopengf changed the title Move MAISI networks from monai.apps to monai.networks Move MAISI networks use monai core components Aug 6, 2024
This was referenced Aug 6, 2024
Merged
Merged
@guopengf guopengf changed the title Move MAISI networks use monai core components Refactor MAISI networks to use monai core components Aug 7, 2024
@guopengf guopengf mentioned this issue Aug 8, 2024
Merged
7 tasks
KumoLiu added a commit that referenced this issue Aug 13, 2024
@guopengf @pre-commit-ci @KumoLiu
Refactor AutoencoderKlMaisi (#7993)
6858114 
Fixes #7988 .

### Description

Refactor AutoencoderKlMaisi to use monai core components.


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Pengfei Guo <32000655+guopengf@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
KumoLiu added a commit that referenced this issue Aug 13, 2024
@guopengf @pre-commit-ci @KumoLiu
Refactor ControlNetMaisi (#8005)
9dbfe16 
Fixes #7988 .

### Description

Refactor ControlNetMaisi to use monai core components.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
rcremese pushed a commit to rcremese/MONAI that referenced this issue Sep 2, 2024
@guopengf @pre-commit-ci @rcremese
Refactor DiffusionModelUNetMaisi (Project-MONAI#7989)
31a550c 
Fixes Project-MONAI#7988 .

### Description

Refactor DiffusionModelUNetMaisi to use monai core components. 

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rcremese pushed a commit to rcremese/MONAI that referenced this issue Sep 2, 2024
@guopengf @pre-commit-ci
@KumoLiu @rcremese
Refactor AutoencoderKlMaisi (Project-MONAI#7993)
b622b7c 
Fixes Project-MONAI#7988 .

### Description

Refactor AutoencoderKlMaisi to use monai core components.


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Pengfei Guo <32000655+guopengf@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
rcremese pushed a commit to rcremese/MONAI that referenced this issue Sep 2, 2024
@guopengf @pre-commit-ci
@KumoLiu @rcremese
Refactor ControlNetMaisi (Project-MONAI#8005)
e336412 
Fixes Project-MONAI#7988 .

### Description

Refactor ControlNetMaisi to use monai core components.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guopengf guopengf

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@guopengf