Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements #271

Merged
merged 3 commits into from
Nov 23, 2022
Merged

small improvements #271

merged 3 commits into from
Nov 23, 2022

Conversation

neildsouth
Copy link
Contributor

Signed-off-by: Neil South neil.south@answerdigital.com

Description

Add task.delay to remove tight loop.

Status

Read

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Neil South <neil.south@answerdigital.com>
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #271 (e6ea3b6) into develop (fcd0247) will decrease coverage by 0.03494%.
The diff coverage is 60.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #271         +/-   ##
===================================================
- Coverage   85.52925%   85.49431%   -0.03495%     
===================================================
  Files            312         312                 
  Lines          18375       18379          +4     
  Branches         893         895          +2     
===================================================
- Hits           15716       15713          -3     
- Misses          2367        2370          +3     
- Partials         292         296          +4     
Flag Coverage Δ
unittests 85.49431% <60.00000%> (-0.03495%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icsGateway/Services/Connectors/PayloadAssembler.cs 77.77778% <42.85714%> (-2.22222%) ⬇️
...aticsGateway/Services/Storage/ObjectUploadQueue.cs 81.25000% <100.00000%> (+4.32692%) ⬆️
...icsGateway/Services/Storage/ObjectUploadService.cs 61.11111% <100.00000%> (ø)
...csGateway/Services/Connectors/PayloadExtensions.cs 88.88889% <0.00000%> (-11.11111%) ⬇️
...maticsGateway/Services/HealthLevel7/MllpService.cs 77.17391% <0.00000%> (-2.17392%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 80.64516% <0.00000%> (-0.71685%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd0247...e6ea3b6. Read the comment docs.

Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth merged commit f85ffe2 into develop Nov 23, 2022
@neildsouth neildsouth deleted the AC-930-nds-improve-preformance branch November 23, 2022 14:49
@mocsharp mocsharp added the bug Something isn't working label Nov 23, 2022
@mocsharp mocsharp added this to the 0.3.5 milestone Nov 23, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

🎉 This issue has been resolved in version 0.3.5 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants