Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support database health checks based on configuration. #282

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Properly support database health checks based on configuration. #282

merged 1 commit into from
Dec 13, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 8, 2022 •
edited
Loading

Description

Fix to support both MongoDB & SQLite DB health checks.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp
Properly support database health checks based on configuration.
49c2b5a 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Dec 8, 2022
@mocsharp mocsharp added this to the 0.3.6 milestone Dec 8, 2022
@mocsharp mocsharp self-assigned this Dec 8, 2022
@mocsharp mocsharp requested a review from neildsouth December 8, 2022 20:29
@mocsharp mocsharp merged commit cb54360 into develop Dec 13, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.6 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neildsouth neildsouth neildsouth approved these changes

@jackschofield23 jackschofield23 jackschofield23 approved these changes

Assignees

@mocsharp mocsharp

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mocsharp @jackschofield23 @neildsouth