Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Moani.Deploy.Security package to 0.1.2 to support basic auth #289

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 13, 2022

Description

  • Update Moani.Deploy.Security package to 0.1.2 to support basic auth
  • Update other packages & licenses

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the enhancement Enhancement to existing feature label Dec 13, 2022
@mocsharp mocsharp added this to the 0.3.6 milestone Dec 13, 2022
@mocsharp mocsharp requested a review from neildsouth December 13, 2022 18:07
@mocsharp mocsharp self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #289 (30ad69e) into develop (6e54a44) will decrease coverage by 0.01057%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #289         +/-   ##
===================================================
- Coverage   84.10172%   84.09115%   -0.01058%     
===================================================
  Files            321         321                 
  Lines          18914       18914                 
  Branches         906         906                 
===================================================
- Hits           15907       15905          -2     
- Misses          2707        2708          +1     
- Partials         300         301          +1     
Flag Coverage Δ
unittests 84.09115% <ø> (-0.01058%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icsGateway/Services/Connectors/PayloadAssembler.cs 77.77778% <0.00000%> (-1.23457%) ⬇️
...ormaticsGateway/Services/Scp/ScpServiceInternal.cs 76.28866% <0.00000%> (-1.03094%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e54a44...30ad69e. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 4c7c599 into develop Dec 15, 2022
@mocsharp mocsharp deleted the vchang/update-security branch December 15, 2022 00:16
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.6 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants