Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Plug-ins in Build #456

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Include Plug-ins in Build #456

merged 2 commits into from
Aug 25, 2023

Conversation

neildsouth
Copy link
Contributor

Description

Fixes # .

Docker build for new external App Plugins

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

…ppExecution.dll across

Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth added the enhancement Enhancement to existing feature label Aug 25, 2023
@neildsouth neildsouth added this to the 0.4.0 milestone Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #456 (b069e17) into develop (2eacbce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop        #456   +/-   ##
=============================================
  Coverage   80.03701%   80.03701%           
=============================================
  Files            379         379           
  Lines          23779       23779           
  Branches        1088        1088           
=============================================
  Hits           19032       19032           
  Misses          4378        4378           
  Partials         369         369           
Flag Coverage Δ
unittests 80.03701% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eacbce...b069e17. Read the comment docs.

@neildsouth neildsouth requested a review from mocsharp August 25, 2023 15:09
@mocsharp mocsharp changed the title Nds fix io plugin copy Include Plug-ins in Build Aug 25, 2023
@neildsouth neildsouth merged commit d619c62 into develop Aug 25, 2023
@neildsouth neildsouth deleted the nds-fix-IOPlugin-copy branch August 25, 2023 15:27
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants