Nds changeplugin config #479
Conversation
src/InformaticsGateway/Services/Common/OutputDataPluginEngine.cs
Outdated
Show resolved
Hide resolved
src/Database/DatabaseManager.cs
Outdated
| @@ -63,16 +63,16 @@ public static IHealthChecksBuilder AddDatabaseHealthCheck(this IHealthChecksBuil | |||
| } | |||
| } | |||
|
|
|||
| public static IServiceCollection ConfigureDatabase(this IServiceCollection services, IConfigurationSection? connectionStringConfigurationSection, ILogger logger) | |||
| => services.ConfigureDatabase(connectionStringConfigurationSection, new FileSystem(), logger); | |||
| public static IServiceCollection ConfigureDatabase(this IServiceCollection services, IConfigurationSection? connectionStringConfigurationSection, IConfigurationSection? pluginsConfigurationSection, ILogger logger) | |||
There was a problem hiding this comment.
Is pluginsConfigurationSection used?
There was a problem hiding this comment.
Not ATM but will be for a plugin were writing and would be the way to pass plugin config for future plugins, also i think that this is better than adding extra stuff into the connection strings section.
Codecov Report
@@ Coverage Diff @@
## develop #479 +/- ##
===================================================
+ Coverage 78.82262% 78.87427% +0.05164%
===================================================
Files 390 390
Lines 24512 24553 +41
Branches 1098 1098
===================================================
+ Hits 19321 19366 +45
+ Misses 4801 4799 -2
+ Partials 390 388 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Neil South <neil.south@answerdigital.com>
neildsouth
force-pushed
the
nds-changeplugin-config
branch
from
62e17c1 to
df65034
Compare
Signed-off-by: Neil South <neil.south@answerdigital.com>
There was a problem hiding this comment.
did we add an empty file here? do we need it?
There was a problem hiding this comment.
its not empty, just no visible diff. change in mode
| @@ -19,5 +19,9 @@ namespace Monai.Deploy.InformaticsGateway.PlugIns.RemoteAppExecution | |||
| internal static class SR | |||
There was a problem hiding this comment.
No idea! something Victor added there are 4 SR.cs files throughout the solution! all contain static strings
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
moving config around for databases to consolidate it
also adding extendable config for plugins
Status
Work in progress
Types of changes