Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DicomAssociation Controller #480

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Conversation

lillie-dae
Copy link
Contributor

@lillie-dae lillie-dae commented Sep 20, 2023

Description

Implementation for the Dicom Association Controller

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #480 (1bcb32b) into develop (047406b) will increase coverage by 0.02304%.
Report is 1 commits behind head on develop.
The diff coverage is 81.77340%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #480         +/-   ##
===================================================
+ Coverage   78.81182%   78.83486%   +0.02304%     
===================================================
  Files            379         390         +11     
  Lines          24306       24512        +206     
  Branches        1083        1098         +15     
===================================================
+ Hits           19156       19324        +168     
- Misses          4775        4800         +25     
- Partials         375         388         +13     
Flag Coverage Δ
unittests 78.83486% <81.77340%> (+0.02304%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/Configuration/InformaticsGatewayConfiguration.cs 100.00000% <ø> (ø)
...ticsGateway/Services/Common/Pagination/Response.cs 28.57143% <28.57143%> (ø)
...ormaticsGateway/Services/Http/ApiControllerBase.cs 40.00000% <40.00000%> (ø)
...base/MongoDB/Repositories/MongoDBRepositoryBase.cs 53.33333% <53.33333%> (ø)
...formaticsGateway/Services/UriService/UriService.cs 55.55556% <55.55556%> (ø)
...csGateway/Services/Common/Pagination/TimeFilter.cs 60.00000% <60.00000%> (ø)
...way/Services/Common/Pagination/PaginationFilter.cs 71.42857% <71.42857%> (ø)
...ay/Services/Http/DicomAssociationInfoController.cs 80.00000% <80.00000%> (ø)
...ormaticsGateway/Services/Scp/ScpServiceInternal.cs 77.22772% <80.00000%> (-0.32330%) ⬇️
...icsGateway/Services/Http/PagedApiControllerBase.cs 81.81818% <81.81818%> (ø)
... and 8 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ceee8a...1bcb32b. Read the comment docs.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae lillie-dae marked this pull request as ready for review September 21, 2023 09:57
@lillie-dae lillie-dae merged commit fefb2ea into develop Sep 22, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants