Ai 382 #508
Merged
Ai 382 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #508 +/- ##
===================================================
- Coverage 65.35326% 63.74703% -1.60624%
===================================================
Files 374 379 +5
Lines 21344 21852 +508
Branches 1332 1333 +1
===================================================
- Hits 13949 13930 -19
- Misses 6886 7413 +527
Partials 509 509
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/InformaticsGateway/Services/Http/HL7DestinationController.cs
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
mehranrashid
approved these changes
Jan 19, 2024
| @@ -240,7 +231,7 @@ private async Task ValidateCreateAsync(MonaiApplicationEntity item) | |||
| { | |||
| throw new ObjectExistsException($"A MONAI Application Entity with the same AE Title '{item.AeTitle}' already exists."); | |||
| } | |||
| if (item.IgnoredSopClasses.Any() && item.AllowedSopClasses.Any()) | |||
| if (item.IgnoredSopClasses.Count != 0 && item.AllowedSopClasses.Count != 0) | |||
There was a problem hiding this comment.
For consistency do you want to change this to is not as well instead of !=. Happy either way
There was a problem hiding this comment.
good point, will do.
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
small tweeks to tidy up
Status
Ready
Types of changes