Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add depart with distance #177

Merged
merged 5 commits into from
Oct 18, 2017
Merged

add depart with distance #177

merged 5 commits into from
Oct 18, 2017

Conversation

lyzidiamond
Copy link
Contributor

@lyzidiamond lyzidiamond commented Oct 17, 2017

Closes #172.

Tasklist

  • Add translation entry in en.js
  • Add tests for continue with distance and depart with distance
  • Add changelog entry
  • Review

cc @mcwhittemore

@@ -125,7 +125,8 @@
"depart": {
"default": {
"default": "Head {direction}",
"name": "Head {direction} on {way_name}"
"name": "Head {direction} on {way_name}",
"namedistance": "Head {direction} on {way_name} for {distance}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the absence of #155, do we need to also add this line to all the other translation files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... if we're going to do that, I'd like to use depart name rather than the english here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this!

@lyzidiamond
Copy link
Contributor Author

Okay @mcwhittemore one last review and then we should be able to merge here.

Copy link
Contributor

@mcwhittemore mcwhittemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a language wide test for continue.stright and then feel free to merge.

@lyzidiamond lyzidiamond merged commit fb54072 into master Oct 18, 2017
@lyzidiamond lyzidiamond deleted the depart-distance branch October 18, 2017 23:32
lyzidiamond added a commit that referenced this pull request Oct 19, 2017
…ize` that allows you to manipulate any token value after any grammar or capitalization rules are applied but before the value is inserted into the instruction. [#170](#170)

- Removed the `options` parameter to this module, including the `tokenizedInstruction` hook. Use the `formatToken` option instead. [#170](#170)
- Added `namedistance` option to the depart instructions and added tests for `namedistance` in depart and continue instructions. Some typo fixes. [#177](#177 (comment))
@lyzidiamond lyzidiamond mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants