-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add depart with distance #177
Conversation
@@ -125,7 +125,8 @@ | |||
"depart": { | |||
"default": { | |||
"default": "Head {direction}", | |||
"name": "Head {direction} on {way_name}" | |||
"name": "Head {direction} on {way_name}", | |||
"namedistance": "Head {direction} on {way_name} for {distance}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the absence of #155, do we need to also add this line to all the other translation files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm... if we're going to do that, I'd like to use depart name
rather than the english here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this!
Okay @mcwhittemore one last review and then we should be able to merge here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a language wide test for continue.stright and then feel free to merge.
…ize` that allows you to manipulate any token value after any grammar or capitalization rules are applied but before the value is inserted into the instruction. [#170](#170) - Removed the `options` parameter to this module, including the `tokenizedInstruction` hook. Use the `formatToken` option instead. [#170](#170) - Added `namedistance` option to the depart instructions and added tests for `namedistance` in depart and continue instructions. Some typo fixes. [#177](#177 (comment))
Closes #172.
Tasklist
en.js
cc @mcwhittemore