Directions (Routes) and AR Polylines #159

intere · 2019-02-18T21:38:44Z

Attempt at fixing merge conflicts with #26.

The original update info is:

a lot of code refactored
added ability to display routes on AR view
added a PR template
added a .travis.yml to lint the pod
added a 'changelog.md' file to track library updates / changes

TODO

Factor LocationNode and AnnotationNode out of LocationAnnotationNode.swift and back into LocationNode.swift
Verify pod installation in an external project (I'll use my ARCL branch in GeoTrackKit for this)
Test the routing (I'll use my ARCL branch in GeoTrackKit for this)
Add a UI to test polyline routing in the example app

Updates

updates the swiftlint rules
- addresses many swiftlint issues in code
makes many things more "swifty" (forEach function blocks instead of for loops for example)
updated the ARCL.podspec file to contain the swift_version
removed .swift_version file (Podspec is now responsible for it)
adds the ability to display a route in the AR view

Checklist

Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
Documentation has been added to all open, and public scoped methods and properties.
Changelog has been updated
Deferred ~~Tests have have been added to all new features. (not a requirement, but helpful)~~
Image/GIFs have been added for all UI related changed.

Screenshots

First Demo: the polyline route demo:

Second Demo: the (original) annotations

fix code style

…piles and the pod lib lints.

…oject to not directly reference the source from the pod in the project, but rather use it via cocoapods.

aaronbrethorst

Generally looks good. I noticed a few stylistic things. I'll put time into functional testing on a device later today.

ARCL/Source/Location Manager/SceneLocationManager.swift

ARCL/Source/Nodes/LocationNode.swift

ARCL/Source/Nodes/PolylineNode.swift

aaronbrethorst · 2019-02-19T23:05:08Z

ARCL/Source/SceneLocationViewEstimateDelegate.swift

+@available(iOS 11.0, *)
+public extension SceneLocationViewEstimateDelegate {
+    func didAddSceneLocationEstimate(sceneLocationView: SceneLocationView, position: SCNVector3, location: CLLocation) {
+        //


Does this need to exist?

The idea is that they are default implementations of the functions (essentially making them optional when conforming to the protocol). They don't have to exist, but by existing, they allow you to choose which functions you want to implement and not have no-op implementations for the ones you don't want to implement.

aaronbrethorst · 2019-02-19T23:05:20Z

ARCL/Source/SceneLocationViewEstimateDelegate.swift

+@available(iOS 11.0, *)
+public extension SceneLocationViewDelegate {
+    func didAddSceneLocationEstimate(sceneLocationView: SceneLocationView, position: SCNVector3, location: CLLocation) {
+        //


does this need to exist?

The idea is that they are default implementations of the functions (essentially making them optional when conforming to the protocol). They don't have to exist, but by existing, they allow you to choose which functions you want to implement and not have no-op implementations for the ones you don't want to implement.

ARKit+CoreLocation/ViewController.swift

…print statements, though; not CocoaLumberjack).

…ng them in AR, however I haven't wired it up to the map yet.

intere · 2019-02-20T17:45:44Z

@aaronbrethorst - thanks for the feedback. I've responded and/or updated based on your feedback. I have started working on updating the UI and have hacked together the ability to specify a location, search for it, get directions and see those directions as a polyline in AR, however the settings UI is janky and I need to clean it up and polish it more.

…shortly.

… as a gate for the PR.

…f the library lints correctly).

…search. 2. Search results are sorted by distance to you.

aaronbrethorst

looks 👍 awesome work!

Ilya Seliverstov and others added 23 commits February 18, 2019 09:04

added swiftlint

ac1e88e

fix code style

Leftovers from cherry-pick.

fb25f0f

Added missing file.

b9ed5f6

code style fixes

2056f02

fix code style

0d2c37b

default implementations for delegate functions

ba93b98

default implementations for delegate functions

a901a49

move SceneLocationViewDelegate to dedicated file

48f7341

add/remove arrays of nodes

45ca2a3

Nuked the orig file.

a28b50a

use storyboard instead of hardcoding UI for demo app

4614baa

More updates.

1812794

code refactoring

cef8bb8

Updates to let the app run.

9743ac4

code refactoring

41c90db

fix podspec

5701493

Updates to address pod linting and ensuring things compile propertly.

053be5d

fix func/variables access levels

f835243

draw routs in scene

fc67e61

remove routes

63e010f

Fixed the podspec and updated the PolylineNode so that everything com…

b3cb308

…piles and the pod lib lints.

Refactored the Podfile to use the local pod source and updated the pr…

85ded70

…oject to not directly reference the source from the pod in the project, but rather use it via cocoapods.

Merge remote-tracking branch 'upstream/master' into polylines

c65b6d1

intere added enhancement under construction not ready to be merged yet, still in progress labels Feb 18, 2019

intere self-assigned this Feb 18, 2019

intere added 2 commits February 18, 2019 14:54

Some cleanup.

39ac915

Exposing some properties that should be public.

43c9216

intere mentioned this pull request Feb 19, 2019

Polylines #26

Closed

aaronbrethorst changed the title ~~Polylines~~ Not for Merge: Polylines Feb 19, 2019

aaronbrethorst requested changes Feb 19, 2019

View reviewed changes

intere added 2 commits February 19, 2019 20:38

PR feedback updates and hooked the debugging function back up (using …

ba41ccb

…print statements, though; not CocoaLumberjack).

I've got a weak UI that barely works for getting directions and showi…

7079a47

…ng them in AR, however I haven't wired it up to the map yet.

intere added 2 commits February 21, 2019 07:39

I'm closing in on a working demo for Points of Interest and directions.

d2738fb

I've completed the demo and added soome comments. I'll update the PR …

8945a4f

…shortly.

intere removed the under construction not ready to be merged yet, still in progress label Feb 22, 2019

intere added 4 commits February 22, 2019 08:49

Added a PR template.

d1fc4c4

Added a changelog and update the PR template to include updating this…

3c1565f

… as a gate for the PR.

Added a travis config that just does a pod lib lint (to let us know i…

a500958

…f the library lints correctly).

Added 2 UX improvements: 1. hitting enter on the keyboard executes a …

cb7df11

…search. 2. Search results are sorted by distance to you.

intere requested a review from aaronbrethorst February 22, 2019 16:18

intere changed the title ~~Not for Merge: Polylines~~ Directions (Routes) and AR Polylines Feb 22, 2019

aaronbrethorst approved these changes Feb 28, 2019

View reviewed changes

aaronbrethorst merged commit 8698199 into AndrewHartAR:master Feb 28, 2019

intere deleted the polylines branch April 29, 2019 16:39

intere mentioned this pull request May 17, 2019

How can I add the navigation Line like your video demo? #106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Directions (Routes) and AR Polylines #159

Directions (Routes) and AR Polylines #159

intere commented Feb 18, 2019 •

edited

Loading

aaronbrethorst left a comment

aaronbrethorst Feb 19, 2019

intere Feb 20, 2019

aaronbrethorst Feb 19, 2019

intere Feb 20, 2019

intere commented Feb 20, 2019

aaronbrethorst left a comment

Directions (Routes) and AR Polylines #159

Directions (Routes) and AR Polylines #159

Conversation

intere commented Feb 18, 2019 • edited Loading

TODO

Updates

Checklist

Screenshots

aaronbrethorst left a comment

Choose a reason for hiding this comment

aaronbrethorst Feb 19, 2019

Choose a reason for hiding this comment

intere Feb 20, 2019

Choose a reason for hiding this comment

aaronbrethorst Feb 19, 2019

Choose a reason for hiding this comment

intere Feb 20, 2019

Choose a reason for hiding this comment

intere commented Feb 20, 2019

aaronbrethorst left a comment

Choose a reason for hiding this comment

intere commented Feb 18, 2019 •

edited

Loading