-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interact with location nodes #197
Interact with location nodes #197
Conversation
…nerated by PolylineNode are touched
… them through the LNTouchDelegate
… them through the LNTouchDelegate
(Closing the PR for now to do extra local tests) |
SCNnode already has a |
Hi @Pilot-Marc, I'm reusing the existing func locationNodeTouched(node: LocationNode) {
guard let name = node.tag else { return }
guard let selectedNode = node.childNodes.first(where: { $0.geometry is SCNBox }) else { return }
... The goal of this PR is to basically pass the identifier when generating multiple polylines. |
@matsoftware I was working on the same issue, detecting what node I was tapping on, but you beat me to it. |
@aaronbrethorst / @Pilot-Marc Changelog and README updated |
…cation into enable-direction-nodes-touch # Conflicts: # Pods/Pods.xcodeproj/project.pbxproj
@matsoftware - could you resolve the merge conflicts, please? |
changelog.md
Outdated
@@ -7,6 +7,7 @@ | |||
- [PR #203 - InfoLabel includes additional heading data](https://github.com/ProjectDent/ARKit-CoreLocation/pull/203) | |||
- [PR #198 - Adds support for AR Orientation Tracking](https://github.com/ProjectDent/ARKit-CoreLocation/pull/198) | |||
- [PR #193 - Adds support for Swift Package Manager](https://github.com/ProjectDent/ARKit-CoreLocation/pull/193) | |||
- [PR #197 - Interact with location nodes](https://github.com/ProjectDent/ARKit-CoreLocation/pull/197) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move this line to the 1.2.2 section (1.2.1 has been released). That section will be visible after you merge with the develop
branch.
…cation into enable-direction-nodes-touch # Conflicts: # Pods/Pods.xcodeproj/project.pbxproj # Sources/ARKit-CoreLocation/Nodes/LocationNode.swift
Changes pushed @intere |
Background
This PR enables the interaction with the direction boxes added to the scene.
Breaking Changes
The
LNToucheDelegate
interfaces has been modified to notify the touch event of both anAnnotationNode
and aLocationNode
, that's represented by the parent of theSCNBox
rendered.The
PolylineNode
class is enriched with atag
attribute that can be used to identify the touched element.Meta
Checklist
open
, andpublic
scoped methods and properties.Screenshots