Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo app: pause/resume when app enters background and returns to foreground #222

Merged
merged 8 commits into from
Oct 10, 2019
Merged

Demo app: pause/resume when app enters background and returns to foreground #222

merged 8 commits into from
Oct 10, 2019

Conversation

halmueller
Copy link
Collaborator

Call begin/endAppearanceTransition when app enters/leaves background, to trigger view controller viewWillDisappear/viewWillAppear.

Background

POIViewController uses calls to viewWillDisappear/viewWillAppear to call pause/run on the
SceneLocationView. Those calls aren't triggered if the app goes into background mode. So we'll invoke beginAppearanceTransition and endAppearanceTransition from app delegate callbacks.

Breaking Changes

None. But a background/foreground transition now exercises the bug noted in #221.

Meta

  • Tied to Version Release(s):

PR Checklist

  • CI runs clean?
  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

@halmueller
Call begin/endAppearanceTransition when app enters/leaves background,…
f978fcc 
… to trigger view controller viewWillDisappear/viewWillAppear.
intere
intere requested changes Sep 6, 2019
View reviewed changes
Copy link
Collaborator

@intere intere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the changelog with your PR link?

@halmueller
Copy link
Collaborator Author

Done.

@halmueller
Copy link
Collaborator Author

Please don’t merge this yet. I’ll mod per Slack conversation and push, but not until next week.

@halmueller
Copy link
Collaborator Author

Ready to merge.

@intere intere merged commit e53803e into AndrewHartAR:develop Oct 10, 2019
@halmueller halmueller deleted the demoApp branch November 25, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intere intere intere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halmueller @intere