Allow adjustment of a LocationAnnotationNode's Y screen coordinate. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to be drawn above, at, or below a node's actual position on screen.
halmueller
changed the title
intere
approved these changes
Oct 10, 2019
|
Can you please resolve the merge conflicts? |
|
Done and passing. |
intere
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Existing codebase translates a
LocationAnnotationNode's rendered label up by ahardcoded factor of 1.1 *
scaleFactor. This means labels are never drawn on the objectthey're labeling, which is sometimes not the desired behavior.
Resolves #229.
Breaking Changes
None. New property's default value is the original 1.1 magic number.
Meta
PR Checklist
open, andpublicscoped methods and properties.Screenshots