Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devServer host configuration not working #167

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 16, 2019 · 5 comments · Fixed by #168
Closed
1 of 5 tasks

devServer host configuration not working #167

thescientist13 opened this issue Aug 16, 2019 · 5 comments · Fixed by #168
Assignees
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP v0.3.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 16, 2019

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

When setting devServer.host as per the documentation, e.g.

  devServer: {
    host: 'local.thegreenhouse.io'
  }

I get this error from Greenwood

Error: greenwood.config.js devServer host type must be a valid url, including http://.  Passed value was: local.thegreenhouse.io
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This is likely a result of this change to fix devServer loading?

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP labels Aug 16, 2019
@thescientist13 thescientist13 added this to the POC milestone Aug 16, 2019
@thescientist13 thescientist13 self-assigned this Aug 16, 2019
@thescientist13
Copy link
Member Author

Hmm, if I change this to pathname then there is no error, but I get Invalid Host Error in the browser..
Screen Shot 2019-08-16 at 7 03 03 PM

@thescientist13
Copy link
Member Author

It works fine on http://localhost:1981/, fwiw.

@thescientist13
Copy link
Member Author

Nice, found this quick fix, to add disableHostCheck: true to devServer config

@thescientist13
Copy link
Member Author

here's hoping we can try and get some more unit tests on our develop task 😢

@thescientist13
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP v0.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant