-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 278 graphql plugin #487
Enhancement/issue 278 graphql plugin #487
Conversation
Took a little time to look into #347 and #349 to see if there were any quick wins but there as the new baseline is specifically targeted towards SSG, there would at least need to be an MPA (or SPA) option in place in order to be able to keep existing data in memory, since as of right now, every page is a hard load. Will move those two issues to deferred and will plan to schedule them for the next Project. |
Was hoping closing and reopening would trigger a Netlify build a la #489 but didn't seem to happen. Maybe because no change in git hash? |
11acd31
to
6164d82
Compare
* init commit of WIP with server and graphiql working * WIP client side implementation * output message when processing a commonjs file * debug statement * custom graphql client * restore graphQL to shelf * refactor shelf * rollup bundling working * graphql working in production build * upgrade backend apollo 3 * move and re-enable data unit tests * align server start usage with develop command * fixed bug with dangling commas in es-modules-shims * add new config query test case * tests for menu query for navigation * clean up * add support for children query aliasing * children query specs * cleanup * graph query test cases and support * delete old cases * console cleanup * fix label confusion and restore id * remove frontmatter * refactoring and promisifying * graph test with custom frontmatter * restore docs * remove example config query * delete commented out code
* init commit of WIP with server and graphiql working * WIP client side implementation * output message when processing a commonjs file * debug statement * custom graphql client * restore graphQL to shelf * refactor shelf * rollup bundling working * graphql working in production build * upgrade backend apollo 3 * move and re-enable data unit tests * align server start usage with develop command * fixed bug with dangling commas in es-modules-shims * add new config query test case * tests for menu query for navigation * clean up * add support for children query aliasing * children query specs * cleanup * graph query test cases and support * delete old cases * console cleanup * fix label confusion and restore id * remove frontmatter * refactoring and promisifying * graph test with custom frontmatter * restore docs * remove example config query * delete commented out code
Related Issue
resolves #278
Summary of Changes
<app-header>
and<app-shelf>
components to useclient
load
handling for serving custom resourcesTODOs
@apollo/client
support in client.js (see thoughts below) - added as a Roadmap to 1.0 Tracking itemThoughts / Questions
Apollo Client
There were a number of issues / hacks / workarounds I bumped into while trying to use
@apollo/client
in client.js so I have put that work into a branch for now, but will still try and kick the tires for a bit longer@apollo/client
's dependencies still being CommonJS (fast-json-stable-stringify), including our plugin-import-commonjs was requiredexport
, which I had to handle usingintercept
@apollo/client
package's node_modulesgetQueryHash
for the time being since Apollo isn't available on the client nowUltimately landed on this bug, same thing happened in
apollo-client
. 😞Refactoring / Tracking Items
import
as the spec says they should always be there but for now, will make it so node_modules can be bare, and can make an issue to add support for bare module specifier as a pluginimportMaps
like in plugin-babel /regenerator-runtime
import
on NodeJS codeserver.stop
handling onprocess
endcreateCache
round-robin 🐦