Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Attributes support in Acorn #173

Closed
thescientist13 opened this issue Nov 14, 2024 · 0 comments · Fixed by #175
Closed

Import Attributes support in Acorn #173

thescientist13 opened this issue Nov 14, 2024 · 0 comments · Fixed by #175
Assignees
@thescientist13
Labels
enhancement Improvement to existing functionality v0.15.1

Comments

@thescientist13
Copy link
Member

Type of Change

Enhancement

Summary

As per ProjectEvergreen/greenwood#1317, Acorn now supports import attributes natively and working great! 🎉
https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#8140-2024-10-27

Details

So we should now be able to remove the dependency on acorn-import-attributes, and may need to bump Rollup too.
@thescientist13 thescientist13 added enhancement Improvement to existing functionality v0.15.1 labels Nov 14, 2024
@thescientist13 thescientist13 self-assigned this Nov 14, 2024
This was referenced Nov 14, 2024
Open
Merged
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Nov 14, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Phase 10 - Ecosystem Compat Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
enhancement Improvement to existing functionality v0.15.1
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement/issue 173 native import attributes ProjectEvergreen/wcc
1 participant
@thescientist13