Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to enable/disable the plugin in Mirador's config #78

Open
D-Groenewegen opened this issue Aug 14, 2023 · 1 comment
Open

Comments

@D-Groenewegen
Copy link

Currently, there is no configuration option to let you either enable or disable the plugin. When you've imported it for a module bundler like Webpack, it must be configured and made available. It would be more user-friendly if the option could be set in Mirador's config object. The alternative is to create two separate builds of Mirador, one with and the other without the plugin, which is a little cumbersome.

Suggestion

  • Add the config option enabled under annotations, much as has been done for other plugins like CanvasLink and TextOverlay
  • Make it a boolean. Default value: true.
  • Possibly, make it a window-specific option.

P.S. I did notice that the ImageTools plugin does things a little differently. Maybe it's up to the Mirador developers to standardise the way a plugin can be switched on/off.

@D-Groenewegen
Copy link
Author

Just a minor update. While I still think this would be a useful option, I have now solved things differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant