New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canvasIndex should override manifest startCanvas #4071

Open

chchch opened this issue Jan 3, 2025 · 0 comments

chchch commented Jan 3, 2025

In this file, change:

mirador/src/state/sagas/windows.js

Lines 104 to 106 in 5daa657

    
           const startCanvas = miradorManifest.startCanvas 
        
             || miradorManifest.canvasAt(canvasIndex || 0) 
        
             || miradorManifest.canvasAt(0);

To:

      const startCanvas = canvasIndex ? miradorManifest.canvasAt(canvasIndex) :
        miradorManifest.startCanvas || miradorManifest.canvasAt(0);

Otherwise, if a manifest has a startCanvas set, then it will override the user-defined canvasIndex property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment