Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ESLint errors across the application #268

Open
1 task
drewclem opened this issue Apr 7, 2021 · 8 comments
Open
1 task

Clean up ESLint errors across the application #268

drewclem opened this issue Apr 7, 2021 · 8 comments
Assignees

Comments

@drewclem
Copy link
Collaborator

drewclem commented Apr 7, 2021

Goal

Now that we have the configuration being picked up thanks to #185, we can start fixing eslint issues. This is an all encompassing issues for eslint errors.

Reason

When you run eslint, there are a lot of errors

Tips

  • First step is to run yarn eslint --fix pages/**/*.js (swap pages for any other folder name to lint them instead: i.e. yarn eslint --fix components/**/*.js to automatically fix any errors that eslint is capable of fixing. ESLint will also provide a list of remaining errors in the terminal.
  • Batch your PR's by page (i.e.: All eslint fixes for post-a-job.js and any related components will be a single PR)

Definition of Done

  • There are no more eslint errors for the page you've decided to work on and the application functions just as it did before the lint errors were fixed.
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

Thanks so much for submitting an issue! We have received it, will review it soon and follow up.
For our contibution guidelines, please check out our contributors guide.

@crisbnp
Copy link
Contributor

crisbnp commented Apr 9, 2021

I'll work on this!

@seanwash
Copy link
Collaborator

Hey @crisbnp, are you still working on this or is it up for grabs? If it's up for grabs I can start tackling some of them!

@crisbnp
Copy link
Contributor

crisbnp commented May 12, 2021

Hey @seanwash ! I started working on this but currently working another open issue. Feel free to pick this up👍

@seanwash
Copy link
Collaborator

🙌 Awesome! I'll self assign.

@seanwash seanwash self-assigned this May 12, 2021
@Seremba
Copy link

Seremba commented Jun 22, 2021

hello @seanwash, are you working on this issue? Would love to give it a try in case you are not working on it. Thanks

@seanwash
Copy link
Collaborator

seanwash commented Sep 4, 2021

@Seremba go ahead!

@nickytonline nickytonline assigned Seremba and unassigned seanwash Sep 5, 2021
@nickytonline
Copy link
Contributor

I've assigned it to you @Seremba. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants