Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep favorited applications in sync #292

Open
1 task
drewclem opened this issue May 13, 2021 · 3 comments
Open
1 task

Keep favorited applications in sync #292

drewclem opened this issue May 13, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@drewclem
Copy link
Collaborator

Goal

This will fix a bug in where the highlighting of the favorited icon gets out of sync between the job detail and applicant review pages

Context

Company users have the ability to favorite applications from any view where they see the list of applicants.

Currently, if you favorite an application and then click into a detailed applicant view, the previously favorited item does not reflect the favorited state. However, a refresh or navigating back to the previous page updates.

Notes

The firebase end of things work, but firebase is promise-based- so maybe its missing an await?

Definition of Done

  • favorited icon in the company job review flow updates and stays synced across routes

Out of scope

@drewclem drewclem added the bug Something isn't working label May 13, 2021
@github-actions
Copy link

Thanks so much for submitting an issue! We have received it, will review it soon and follow up.
For our contibution guidelines, please check out our contributors guide.

@AlexVCS
Copy link
Contributor

AlexVCS commented Jun 10, 2021

I'd like to try and fix this bug!

@drewclem
Copy link
Collaborator Author

@AlexVCS Go for it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants