Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable eslint on build command #339

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

secondl1ght
Copy link

@secondl1ght secondl1ght commented Oct 11, 2021

Closes #325

Description

As per @nickytonline description: On build now with NEXT.js 11, eslint runs as part of the build. Currently it's erroring out with the following lint errors. Reenable linting on builds and fix the lint errors.

Related Tickets and Documents

Issue #325

What gif best describes this PR or how it makes you feel? (optional)

@vercel
Copy link

vercel bot commented Oct 11, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @drewclem on Vercel.

@drewclem first needs to authorize it.

@nickytonline
Copy link
Contributor

@secondl1ght thanks so much for the PR! Removing the configuration to disable linting during the build is part of the issue. The other part is to fix all the lint issues currently being generated. I displayed all the lint issues in the issue, but rereading the issue now, I did not make it clear that the lint errors had to be fixed as well. Let me know if you need any assistance with that.

Looking forward to having this in production. 😎

@secondl1ght
Copy link
Author

I think I will put in a separate PR for fixing the linter issues and we can merge them both at the same time.

@nickytonline
Copy link
Contributor

I think I will put in a separate PR for fixing the linter issues and we can merge them both at the same time.

The lint fixes will need to be merged first and then we can merge this PR. Otherwise, the build will fail like it currently is in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable eslint on build command
2 participants