[ Feat ] Use TTY mode on Process Facade #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28
Using TTY Mode on the Process facade allows us to pass input and output through to the invoked process, preserving colours, and allowing for user interactions.
This also drastically simplifies the architecture of this command by removing the need for a shell script that's sole responsibility is running a list of terminal commands returned by an artisan command who's job it is to build that list.
Some environments don't support TTY mode, like the
gittab in VS code. In this case, there's a fallback with a 5 minutes timeout.The
get-run-cmdCommand has been refactored to update the users hooks automatically.