fix(GODT-1757): Refactor code to have better data separation #91

LBeernaertProton · 2022-08-31T12:24:19Z

Due to Go's lackluster import system we had to refactor certain types
into separate packages so we can better control what each type has
access to.

All the database related code has been moved into the db package.

All the remote user management code has been been moved into the remote
package. Existing remote code has been erased.

All things related to state and snapshot have been moved into the state
package.

To avoid cyclic imports, the state package declares two interfaces which
provide access to some user specific data as well as a custom connector
implementation on which metadata can be attached.

Due to Go's lackluster import system we had to refactor certain types into separate packages so we can better control what each type has access to. All the database related code has been moved into the db package. All the remote user management code has been been moved into the remote package. Existing remote code has been erased. All things related to state and snapshot have been moved into the state package. To avoid cyclic imports, the state package declares two interfaces which provide access to some user specific data as well as a custom connector implementation on which metadata can be attached.

Cleanup the code by remove the apply functions from the user interface. Common code has been put under update_mailbox.go and each separate implementation is charged with pushing the updates. Thanks to this, all the user's connector updates can just be queued as the code is no longer shared between states and user.

internal/backend/user.go

internal/backend/connector_updates.go

internal/state/context.go

tests/fetch_body_test.go

tests/parallel_test.go

tests/run_test.go

tests/benchmark_fetch_test.go

jameshoulahan

All good, just would remove a couple bits of dead code, and you were a bit heavy-handed with the find-replace :)

internal/backend/user.go

internal/errors/errors.go

internal/backend/backend.go

internal/state/connector.go

github-actions · 2022-09-02T07:57:36Z

🎉 This PR is included in version 0.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

LBeernaertProton force-pushed the fix/GODT-1757-improve-data-separation branch 2 times, most recently from 37a99ce to 1131c08 Compare August 31, 2022 12:48

LBeernaertProton force-pushed the fix/GODT-1757-improve-data-separation branch from 1131c08 to 764ffe8 Compare August 31, 2022 13:08

LBeernaertProton enabled auto-merge (squash) August 31, 2022 13:43