Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] adds empty line for help command #565

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[cli] adds empty line for help command #565

merged 1 commit into from
Jan 25, 2021

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Jan 22, 2021

Closes #362

Details:

  • clap 2.X has an issue with adding empty line in the end
  • proper fixing of this problem should be by updating to V3

Resources:

- clap 2.X has an issue with adding empty line in the end
- proper fixing of this problem should be by updating to V3
@damirka damirka added bug Something isn't working feature A new feature. labels Jan 22, 2021
@damirka damirka self-assigned this Jan 22, 2021
@damirka damirka changed the title Adds empty line for help command in leo CLI [cli] adds empty line for help command Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #565 (fd952b8) into master (1a36a26) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   74.57%   74.61%   +0.04%     
==========================================
  Files         472      472              
  Lines       13929    13932       +3     
==========================================
+ Hits        10387    10396       +9     
+ Misses       3542     3536       -6     
Impacted Files Coverage Δ
leo/main.rs 100.00% <ø> (ø)
compiler/src/expression/arithmetic/pow.rs 0.00% <0.00%> (-27.78%) ⬇️
core/src/types/core_package.rs 75.00% <0.00%> (-1.93%) ⬇️
type-inference/src/objects/frame.rs 93.71% <0.00%> (-0.40%) ⬇️
grammar/src/ast.rs 94.38% <0.00%> (ø)
ast/src/expression/mod.rs 85.46% <0.00%> (ø)
ast/src/expression/binary.rs 83.33% <0.00%> (ø)
compiler/src/expression/expression.rs 95.83% <0.00%> (ø)
compiler/src/value/integer/integer.rs 94.57% <0.00%> (ø)
compiler/tests/integers/uint_macro.rs 96.70% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a36a26...fd952b8. Read the comment docs.

Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@collinc97 collinc97 merged commit 5fbced9 into ProvableHQ:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature A new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add line break at the end of Leo CLI command list
3 participants