Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] adds leo add and leo remove CI workflow #569

Closed
wants to merge 1 commit into from
Closed

[ci] adds leo add and leo remove CI workflow #569

wants to merge 1 commit into from

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Jan 25, 2021

Follow up on #551 and #560

What is done

Added CI workflow for leo login, leo add and leo remove commands

Requires ALEO_PM_USERNAME and ALEO_PM_PASSWORD to be set in secrets

Motivation

More tests on CLI, improving developer experience

- requires ALEO_PM_USERNAME and ALEO_PM_PASSWORD to be set in secrets
- follows simple workflow: new-login-add-remove
@damirka damirka self-assigned this Jan 25, 2021
@damirka damirka added the ci label Jan 25, 2021
@damirka damirka changed the title Adds leo add and leo remove CI cycle [ci] adds leo add and leo remove CI workflow Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #569 (2aea36a) into master (dae45d9) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   74.73%   74.37%   -0.36%     
==========================================
  Files         472      472              
  Lines       13932    13932              
==========================================
- Hits        10412    10362      -50     
- Misses       3520     3570      +50     
Impacted Files Coverage Δ
compiler/src/expression/arithmetic/pow.rs 0.00% <0.00%> (-27.78%) ⬇️
compiler/src/expression/arithmetic/mul.rs 0.00% <0.00%> (-23.81%) ⬇️
ast/src/expression/binary.rs 80.55% <0.00%> (-5.56%) ⬇️
compiler/src/value/integer/integer.rs 91.86% <0.00%> (-5.43%) ⬇️
compiler/tests/integers/uint_macro.rs 93.40% <0.00%> (-3.30%) ⬇️
compiler/tests/integers/int_macro.rs 92.15% <0.00%> (-2.95%) ⬇️
grammar/src/ast.rs 93.25% <0.00%> (-2.25%) ⬇️
compiler/src/expression/expression.rs 95.00% <0.00%> (-1.67%) ⬇️
ast/src/expression/mod.rs 85.02% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae45d9...2aea36a. Read the comment docs.

Copy link

@damons damons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping my review on this as I'm just watching progress. Others who are reviewing: Please make sure this PR is complete and sufficient.

@damirka
Copy link
Contributor Author

damirka commented Jan 26, 2021

Impossible to test from fork, did #579 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants