Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"驗證權限"部分需要變成 c-code 的部分. #273

Open
chhsiao1981 opened this issue Nov 20, 2021 · 1 comment
Open

"驗證權限"部分需要變成 c-code 的部分. #273

chhsiao1981 opened this issue Nov 20, 2021 · 1 comment

Comments

@chhsiao1981
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

有大神反應"驗證權限"的部分希望可以直接用 c-code.
go-pttbbs 的 strategy 是跟 c-pttbbs 盡量 1-1 mapping.
所以大致上是可行的~

A clear and concise description of what you want to happen.

目前需要釐清:

  1. 有哪些是希望直接使用 c-code.
  2. 兩邊的 variables 要如何互相 share / copy.

這個 issue 將 list 出需要直接使用 c-code 的部分. 並且記錄相對應的 input/output 的對應.

A clear and concise description of any alternative solutions or features you've considered.

Add any other context or screenshots about the feature request here.

@chhsiao1981
Copy link
Collaborator Author

There are global variables in c-pttbbs (cuser and currboard).

It's better to refactor c-pttbbs to have pure functions (functions without global variables)
for the permission checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant