Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firmware, Refactor code to remove "PubSubClient" from the Hardware Abstraction Layer #129

Open
RobertLRead opened this issue Jan 2, 2025 · 0 comments
Open

Firmware, Refactor code to remove "PubSubClient" from the Hardware Abstraction Layer #129

RobertLRead opened this issue Jan 2, 2025 · 0 comments
Assignees
@RobertLRead
Labels
refactoring
Milestone
Firmware Release

Comments

@RobertLRead
Copy link
Contributor

Describe the bug
This is not a bug, but a code quality improvement.

The HAL currently references the MQTT PubSubClient library because of an action in the "interpretBuffer" routine, which currently returns a void.

It should be made to return a simple class which will be acted upon by the CALLERs of interpretBuffer. This will allow a future SPI interface to also be handled correctly.
@RobertLRead RobertLRead added this to the Firmware Release milestone Jan 2, 2025
@RobertLRead RobertLRead self-assigned this Jan 2, 2025
@nk25719 nk25719 changed the title Refactor code to remove "PubSubClient" from the Hardware Abstraction Layer Firnware, Refactor code to remove "PubSubClient" from the Hardware Abstraction Layer Jan 11, 2025
@nk25719 nk25719 changed the title Firnware, Refactor code to remove "PubSubClient" from the Hardware Abstraction Layer Firmware, Refactor code to remove "PubSubClient" from the Hardware Abstraction Layer Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertLRead RobertLRead

Labels
refactoring
Projects
None yet
Milestone
Firmware Release
Development

No branches or pull requests
1 participant
@RobertLRead