Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline image support #18

Open
ebuntaran opened this issue Feb 11, 2024 · 1 comment
Open

Inline image support #18

ebuntaran opened this issue Feb 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ebuntaran
Copy link

Support for inline images for puzzle content would be cool

@TheOriginalSoni TheOriginalSoni added the enhancement New feature or request label Feb 11, 2024
@betaveros
Copy link
Contributor

If you just want users to be able to embed images that they've uploaded elsewhere, you can allowlist the <img> tag by adding "img" to SAFE_TAGS in https://github.com/PuzzleTechHub/myus/blob/main/myus/myus/templatetags/markdown.py . I did not allowlist it for privacy/security reasons (by embedding an image from your own website you can get the IP of every viewer, etc.; maybe phishing becomes more plausible?), but those may not be dealbreakers and there are plenty of cool things you can do with them.

If you want users to upload images and inline them, I don't know the best way but it's probably moderately complicated/expensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants