Add new plugin to check use of pyghmi #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch set adds a new bandit plugin to check the use of pyghmi. Signed-off-by: Tin Lam <tin@irrational.io>
Signed-off-by: Tin Lam <tin@irrational.io>
This patch set adds a new bandit plugin to check the use of the pyghmi library, as the IPMI is known to be an insecured protocol. Closes: #356 Signed-off-by: Tin Lam <tin@irrational.io>
ericwb
requested review from
ghugo,
lukehinds and
sigmavirus24
as code owners
ericwb
changed the title
…ipmi This patch set adds a new bandit plugin to check the use of pyghmi. Closes #356 Signed-off-by: Tin Lam tin@irrational.io Signed-off-by: Eric Brown <browne@vmware.com>
sigmavirus24
approved these changes
Feb 7, 2022
This was referenced Feb 28, 2022
Merged
This was referenced Feb 28, 2022
chore(deps): update pre-commit hook pycqa/bandit to v1.7.3
browniebroke/flake8-django-migrations#174
Merged
Merged
LarsMichelsen
pushed a commit
to Checkmk/checkmk
that referenced
this pull request
Mar 7, 2022
This updated bandit to 1.7.4. In 1.7.3 check [B303], hash functions, was updated and [B415], IMPI protocol, was added. Hash Function ============= A lower threshold for insecure hash functions was introduced. All offending code places have been updated with `usedforsecurity=False` to make bandit happy. This might have not been ideal in all cases. I'm currently not sure how a change in hashing algorithm would affect back wards compatibility. IMPI Protocol ============== The IMPI protocol is considered insecure. We use it exentsivly in core parts of the code. For now ignore this check. [B303] PyCQA/bandit#748 [B415] PyCQA/bandit#803 Change-Id: Iee36820d152955bbd31e6b21fdd6bbc5b83dbb1c
This was referenced Mar 7, 2022
This was referenced Mar 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch 'feat/pyghmi' of ssh://github.com/stannum-l/bandit into ipmi
Signed-off-by: Eric Brown browne@vmware.com
This patch set adds a new bandit plugin to check the use of pyghmi.
Closes #356
Signed-off-by: Tin Lam tin@irrational.io