Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve B018 further #202

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Improve B018 further #202

merged 1 commit into from
Nov 22, 2021

Conversation

kasium
Copy link
Contributor

@kasium kasium commented Nov 15, 2021

Catch also useless expressions on the first node in a body if the node is not a string (docstring).
Thanks to @asottile for the idea.

Part of #201

Catch also useless expressions on the first node in a body if the node is not a string (docstring).
@kasium
Copy link
Contributor Author

kasium commented Nov 15, 2021

@cooperlees can you please take a look in the test failures?

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense to me. Thanks all. Will wait and allow some others to disagree and then try and get a release out this week.

@cooperlees cooperlees merged commit 98829c3 into PyCQA:master Nov 22, 2021
@kasium kasium deleted the issue-201-3 branch November 22, 2021 17:03
@kasium
Copy link
Contributor Author

kasium commented Nov 22, 2021

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants