Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build universal Python 3 wheels #214

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Build universal Python 3 wheels #214

merged 1 commit into from
Jan 7, 2022

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented Jan 7, 2022

Pure Python 3 packages need not include any configuration for bdist_wheel. Currently the wheels on PyPI could look to someone new as if they only support Python 3.6-3.8

But CI is in fact testing through 3.10:

python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]

Supported Python versions are enforced through:

python_requires=">=3.6",

This change will build proper *-py3-none-any.whl wheels.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this and I’ve been meaning to do it. Also need to move to the new wheel building tool (who’s name I forget - someone moved black). Thanks for this. I’ll merge and try get a release out soon.

@cooperlees cooperlees merged commit c0a9c87 into PyCQA:master Jan 7, 2022
@johnthagen johnthagen deleted the patch-1 branch January 7, 2022 13:49
@johnthagen
Copy link
Contributor Author

johnthagen commented Jan 7, 2022

Also need to move to the new wheel building tool (who’s name I forget - someone moved black).

@cooperlees You are probably referring to the new build tool.

@cooperlees
Copy link
Collaborator

That’s the one. Will accept PR if anyone has spare cycles!

@johnthagen
Copy link
Contributor Author

johnthagen commented Jan 7, 2022

Here is the link to what needs to be added to pyproject.toml to support this:

A blog post about the topic in general that is a good read:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants