-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add B020 check to find for-loop control variable overiding iter set #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Just some wording and doc string suggestions.
Please a change log entry please (It's in the README file too).
Co-authored-by: Cooper Lees <me@cooperlees.com>
Co-authored-by: Cooper Lees <me@cooperlees.com>
Co-authored-by: Cooper Lees <me@cooperlees.com>
Co-authored-by: Cooper Lees <me@cooperlees.com>
Co-authored-by: Cooper Lees <me@cooperlees.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a line to long - We failed a bugbear check on bugbear! haha
Co-authored-by: Cooper Lees <me@cooperlees.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Will be a good addition as I really dislike this and is an easy typo to make ...
Co-authored-by: Cooper Lees <me@cooperlees.com>
Description
A simple typo of the for-loop control variable name
item => items
in loop[items for items in items]
can lead to an unintended change of theitems
variable.Fixes #219