Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream reading via pipe no longer working #895

Closed
timothycrosley opened this issue Mar 11, 2019 · 3 comments
Closed

Stream reading via pipe no longer working #895

timothycrosley opened this issue Mar 11, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@timothycrosley
Copy link
Member

After #883 was merged, < style sorting was improved but | sorting broke completely due to usage of seek()

@timothycrosley timothycrosley added the bug Something isn't working label Mar 11, 2019
@KwatMDPhD
Copy link

I face the same bug. I think I was able to run the following command with version 4.2.3:

echo "import os" | isort -

I think the community would appreciate it if we could make piping work. I can imagine many developers having the same issue (after they upgrade things).

@timothycrosley
Copy link
Member Author

This is fixed in the just release 4.3.15 hot fix release:

https://github.com/timothycrosley/isort/releases/tag/4.3.15

thanks!

~Timothy

@KwatMDPhD
Copy link

Good job @timothycrosley ! And thank you. I'm going to follow you :) Feel free to do the same. I use isort for https://github.com/KwatME/clean_ipynb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants