Fix tests with Python 3.9 #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually, one other thing -- can you remove these lines? Lines 17 to 21 in 684edfc |
|
Done, and it passes! |
|
@asottile do you think you will release a new version soon? If not, I'll simply backport my patches to Gentoo for the time being. |
asottile
reviewed
Oct 3, 2020
| # the PEG parser is currently broken in some cases | ||
| allow_failures: | ||
| - python: nightly | ||
| dist: xenial |
There was a problem hiding this comment.
oh oops now that I look at this, this is 3.10a0 -- should we select 3.9 here explicitly?
There was a problem hiding this comment.
I've set it to 3.9-dev. It seems to be the best way at the moment.
probably not for a while, probably best to backport the patches for now 👍 |
Stop allowing failures on Python nightly.
This was referenced Mar 15, 2021
Merged
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this passes on Travis's nightly Python build. If not, I will probably add 3.9rc2 to the matrix.