From 1e0d45fc04d1d0462b33d2317fec4d479cfe44b0 Mon Sep 17 00:00:00 2001 From: messense Date: Tue, 3 Dec 2024 19:52:33 +0800 Subject: [PATCH] Fix aarch64 Windows cross compilation --- src/compile.rs | 1372 +++++++++++++++-------------- src/cross_compile.rs | 425 +++++---- test-crates/pyo3-mixed/Cargo.lock | 4 +- 3 files changed, 901 insertions(+), 900 deletions(-) diff --git a/src/compile.rs b/src/compile.rs index 1e724bcf2..17670e86f 100644 --- a/src/compile.rs +++ b/src/compile.rs @@ -1,678 +1,694 @@ -use crate::build_context::BridgeModel; -use crate::target::RUST_1_64_0; -#[cfg(feature = "zig")] -use crate::PlatformTag; -use crate::{BuildContext, PythonInterpreter, Target}; -use anyhow::{anyhow, bail, Context, Result}; -use cargo_metadata::CrateType; -use fat_macho::FatWriter; -use fs_err::{self as fs, File}; -use normpath::PathExt; -use std::collections::HashMap; -use std::env; -use std::io::{BufReader, Read}; -use std::path::{Path, PathBuf}; -use std::process::{Command, Stdio}; -use std::str; -use tracing::{debug, instrument, trace}; - -/// The first version of pyo3 that supports building Windows abi3 wheel -/// without `PYO3_NO_PYTHON` environment variable -const PYO3_ABI3_NO_PYTHON_VERSION: (u64, u64, u64) = (0, 16, 4); - -/// crate types excluding `bin`, `cdylib` and `proc-macro` -pub(crate) const LIB_CRATE_TYPES: [CrateType; 4] = [ - CrateType::Lib, - CrateType::DyLib, - CrateType::RLib, - CrateType::StaticLib, -]; - -/// A cargo target to build -#[derive(Debug, Clone)] -pub struct CompileTarget { - /// The cargo target to build - pub target: cargo_metadata::Target, - /// The bridge model to use - pub bridge_model: BridgeModel, -} - -/// A cargo build artifact -#[derive(Debug, Clone)] -pub struct BuildArtifact { - /// Path to the build artifact - pub path: PathBuf, - /// Array of paths to include in the library search path, as indicated by - /// the `cargo:rustc-link-search` instruction. - pub linked_paths: Vec, -} - -/// Builds the rust crate into a native module (i.e. an .so or .dll) for a -/// specific python version. Returns a mapping from crate type (e.g. cdylib) -/// to artifact location. -pub fn compile( - context: &BuildContext, - python_interpreter: Option<&PythonInterpreter>, - targets: &[CompileTarget], -) -> Result>> { - if context.universal2 { - compile_universal2(context, python_interpreter, targets) - } else { - compile_targets(context, python_interpreter, targets) - } -} - -/// Build an universal2 wheel for macos which contains both an x86 and an aarch64 binary -fn compile_universal2( - context: &BuildContext, - python_interpreter: Option<&PythonInterpreter>, - targets: &[CompileTarget], -) -> Result>> { - let mut aarch64_context = context.clone(); - aarch64_context.target = Target::from_target_triple(Some("aarch64-apple-darwin".to_string()))?; - - let aarch64_artifacts = compile_targets(&aarch64_context, python_interpreter, targets) - .context("Failed to build a aarch64 library through cargo")?; - let mut x86_64_context = context.clone(); - x86_64_context.target = Target::from_target_triple(Some("x86_64-apple-darwin".to_string()))?; - - let x86_64_artifacts = compile_targets(&x86_64_context, python_interpreter, targets) - .context("Failed to build a x86_64 library through cargo")?; - - let mut universal_artifacts = Vec::with_capacity(targets.len()); - for (bridge_model, (aarch64_artifact, x86_64_artifact)) in targets - .iter() - .map(|target| &target.bridge_model) - .zip(aarch64_artifacts.iter().zip(&x86_64_artifacts)) - { - let build_type = if bridge_model.is_bin() { - CrateType::Bin - } else { - CrateType::CDyLib - }; - let aarch64_artifact = aarch64_artifact.get(&build_type).cloned().ok_or_else(|| { - if build_type == CrateType::CDyLib { - anyhow!( - "Cargo didn't build an aarch64 cdylib. Did you miss crate-type = [\"cdylib\"] \ - in the lib section of your Cargo.toml?", - ) - } else { - anyhow!("Cargo didn't build an aarch64 bin.") - } - })?; - let x86_64_artifact = x86_64_artifact.get(&build_type).cloned().ok_or_else(|| { - if build_type == CrateType::CDyLib { - anyhow!( - "Cargo didn't build a x86_64 cdylib. Did you miss crate-type = [\"cdylib\"] \ - in the lib section of your Cargo.toml?", - ) - } else { - anyhow!("Cargo didn't build a x86_64 bin.") - } - })?; - // Create an universal dylib - let output_path = aarch64_artifact - .path - .display() - .to_string() - .replace("aarch64-apple-darwin/", ""); - let mut writer = FatWriter::new(); - let aarch64_file = fs::read(&aarch64_artifact.path)?; - let x86_64_file = fs::read(&x86_64_artifact.path)?; - writer - .add(aarch64_file) - .map_err(|e| anyhow!("Failed to add aarch64 cdylib: {:?}", e))?; - writer - .add(x86_64_file) - .map_err(|e| anyhow!("Failed to add x86_64 cdylib: {:?}", e))?; - writer - .write_to_file(&output_path) - .map_err(|e| anyhow!("Failed to create universal cdylib: {:?}", e))?; - - let mut result = HashMap::new(); - let universal_artifact = BuildArtifact { - path: PathBuf::from(output_path), - ..x86_64_artifact - }; - result.insert(build_type, universal_artifact); - universal_artifacts.push(result); - } - Ok(universal_artifacts) -} - -fn compile_targets( - context: &BuildContext, - python_interpreter: Option<&PythonInterpreter>, - targets: &[CompileTarget], -) -> Result>> { - let mut artifacts = Vec::with_capacity(targets.len()); - for target in targets { - let build_command = cargo_build_command(context, python_interpreter, target)?; - artifacts.push(compile_target(context, build_command)?); - } - Ok(artifacts) -} - -fn cargo_build_command( - context: &BuildContext, - python_interpreter: Option<&PythonInterpreter>, - compile_target: &CompileTarget, -) -> Result { - let target = &context.target; - - let mut cargo_rustc: cargo_options::Rustc = context.cargo_options.clone().into(); - cargo_rustc.message_format = vec!["json-render-diagnostics".to_string()]; - - // --release and --profile are conflicting options - if context.release && cargo_rustc.profile.is_none() { - cargo_rustc.release = true; - } - - // Add `--crate-type cdylib` if available - if compile_target - .target - .crate_types - .iter() - .any(|crate_type| LIB_CRATE_TYPES.contains(crate_type)) - { - // `--crate-type` is stable since Rust 1.64.0 - // See https://github.com/rust-lang/cargo/pull/10838 - if target.rustc_version.semver >= RUST_1_64_0 { - debug!("Setting crate_type to cdylib for Rust >= 1.64.0"); - cargo_rustc.crate_type = vec!["cdylib".to_string()]; - } - } - - let target_triple = target.target_triple(); - - let manifest_dir = context.manifest_path.parent().unwrap(); - let mut rustflags = cargo_config2::Config::load_with_cwd(manifest_dir)? - .rustflags(target_triple)? - .unwrap_or_default(); - let original_rustflags = rustflags.flags.clone(); - - // We need to pass --bin / --lib - let bridge_model = &compile_target.bridge_model; - match bridge_model { - BridgeModel::Bin(..) => { - cargo_rustc.bin.push(compile_target.target.name.clone()); - } - BridgeModel::Cffi - | BridgeModel::UniFfi - | BridgeModel::Bindings { .. } - | BridgeModel::BindingsAbi3(..) => { - cargo_rustc.lib = true; - // https://github.com/rust-lang/rust/issues/59302#issue-422994250 - // We must only do this for libraries as it breaks binaries - // For some reason this value is ignored when passed as rustc argument - if context.target.is_musl_libc() - && !rustflags - .flags - .iter() - .any(|f| f == "target-feature=-crt-static") - { - debug!("Setting `-C target-features=-crt-static` for musl dylib"); - rustflags.push("-C"); - rustflags.push("target-feature=-crt-static"); - } - } - } - - // https://github.com/PyO3/pyo3/issues/88#issuecomment-337744403 - if target.is_macos() { - if let BridgeModel::Bindings { .. } | BridgeModel::BindingsAbi3(..) = bridge_model { - // Change LC_ID_DYLIB to the final .so name for macOS targets to avoid linking with - // non-existent library. - // See https://github.com/PyO3/setuptools-rust/issues/106 for detail - let module_name = &context.module_name; - let so_filename = match bridge_model { - BridgeModel::BindingsAbi3(..) => format!("{module_name}.abi3.so"), - _ => python_interpreter - .expect("missing python interpreter for non-abi3 wheel build") - .get_library_name(module_name), - }; - let macos_dylib_install_name = - format!("link-args=-Wl,-install_name,@rpath/{so_filename}"); - let mac_args = [ - "-C".to_string(), - "link-arg=-undefined".to_string(), - "-C".to_string(), - "link-arg=dynamic_lookup".to_string(), - "-C".to_string(), - macos_dylib_install_name, - ]; - debug!("Setting additional linker args for macOS: {:?}", mac_args); - cargo_rustc.args.extend(mac_args); - } - } else if target.is_emscripten() { - // Allow user to override these default flags - if !rustflags - .flags - .iter() - .any(|f| f.contains("link-native-libraries")) - { - debug!("Setting `-Z link-native-libraries=no` for Emscripten"); - rustflags.push("-Z"); - rustflags.push("link-native-libraries=no"); - } - let mut emscripten_args = Vec::new(); - // Allow user to override these default settings - if !cargo_rustc - .args - .iter() - .any(|arg| arg.contains("SIDE_MODULE")) - { - emscripten_args.push("-C".to_string()); - emscripten_args.push("link-arg=-sSIDE_MODULE=2".to_string()); - } - if !cargo_rustc - .args - .iter() - .any(|arg| arg.contains("WASM_BIGINT")) - { - emscripten_args.push("-C".to_string()); - emscripten_args.push("link-arg=-sWASM_BIGINT".to_string()); - } - debug!( - "Setting additional linker args for Emscripten: {:?}", - emscripten_args - ); - cargo_rustc.args.extend(emscripten_args); - } - - if context.strip { - // https://doc.rust-lang.org/rustc/codegen-options/index.html#strip - cargo_rustc - .args - .extend(["-C".to_string(), "strip=symbols".to_string()]); - } - - let mut build_command = if target.is_msvc() - && (target.cross_compiling() || env::var("MATURIN_USE_XWIN").ok().as_deref() == Some("1")) - { - #[cfg(feature = "xwin")] - { - println!("🛠️ Using xwin for cross-compiling to {target_triple}"); - let xwin_options = { - use clap::Parser; - - // This will populate the default values for the options - // and then override them with cargo-xwin environment variables. - cargo_xwin::XWinOptions::parse_from(Vec::<&str>::new()) - }; - - let mut build = cargo_xwin::Rustc::from(cargo_rustc); - build.target = vec![target_triple.to_string()]; - build.xwin = xwin_options; - build.build_command()? - } - #[cfg(not(feature = "xwin"))] - { - if target.user_specified { - cargo_rustc.target = vec![target_triple.to_string()]; - } - cargo_rustc.command() - } - } else { - #[cfg(feature = "zig")] - { - let mut build = cargo_zigbuild::Rustc::from(cargo_rustc); - if !context.zig { - build.disable_zig_linker = true; - if target.user_specified { - build.target = vec![target_triple.to_string()]; - } - } else { - println!("🛠️ Using zig for cross-compiling to {target_triple}"); - build.enable_zig_ar = true; - let zig_triple = if target.is_linux() && !target.is_musl_libc() { - match context.platform_tag.iter().find(|tag| tag.is_manylinux()) { - Some(PlatformTag::Manylinux { x, y }) => { - format!("{target_triple}.{x}.{y}") - } - _ => target_triple.to_string(), - } - } else { - target_triple.to_string() - }; - build.target = vec![zig_triple]; - } - build.build_command()? - } - #[cfg(not(feature = "zig"))] - { - if target.user_specified { - cargo_rustc.target = vec![target_triple.to_string()]; - } - cargo_rustc.command() - } - }; - - #[cfg(feature = "zig")] - if context.zig { - // Pass zig command to downstream, eg. python3-dll-a - if let Ok((zig_cmd, zig_args)) = cargo_zigbuild::Zig::find_zig() { - if zig_args.is_empty() { - build_command.env("ZIG_COMMAND", zig_cmd); - } else { - build_command.env( - "ZIG_COMMAND", - format!("{} {}", zig_cmd.display(), zig_args.join(" ")), - ); - }; - } - } - - build_command - // We need to capture the json messages - .stdout(Stdio::piped()) - // We can't get colored human and json messages from rustc as they are mutually exclusive, - // but forwarding stderr is still useful in case there some non-json error - .stderr(Stdio::inherit()); - - if !rustflags.flags.is_empty() && rustflags.flags != original_rustflags { - build_command.env("CARGO_ENCODED_RUSTFLAGS", rustflags.encode()?); - } - - if let BridgeModel::BindingsAbi3(_, _) = bridge_model { - let is_pypy_or_graalpy = python_interpreter - .map(|p| p.interpreter_kind.is_pypy() || p.interpreter_kind.is_graalpy()) - .unwrap_or(false); - if !is_pypy_or_graalpy && !target.is_windows() { - let pyo3_ver = pyo3_version(&context.cargo_metadata) - .context("Failed to get pyo3 version from cargo metadata")?; - if pyo3_ver < PYO3_ABI3_NO_PYTHON_VERSION { - // This will make old pyo3's build script only set some predefined linker - // arguments without trying to read any python configuration - build_command.env("PYO3_NO_PYTHON", "1"); - } - } - } - - // Setup `PYO3_CONFIG_FILE` if we are cross compiling for pyo3 bindings - if let Some(interpreter) = python_interpreter { - // Target python interpreter isn't runnable when cross compiling - if interpreter.runnable { - if bridge_model.is_bindings("pyo3") - || bridge_model.is_bindings("pyo3-ffi") - || matches!(bridge_model, BridgeModel::BindingsAbi3(_, _)) - { - debug!( - "Setting PYO3_PYTHON to {}", - interpreter.executable.display() - ); - build_command - .env("PYO3_PYTHON", &interpreter.executable) - .env( - "PYO3_ENVIRONMENT_SIGNATURE", - interpreter.environment_signature(), - ); - } - - // rust-cpython, and legacy pyo3 versions - build_command.env("PYTHON_SYS_EXECUTABLE", &interpreter.executable); - } else if (bridge_model.is_bindings("pyo3") - || bridge_model.is_bindings("pyo3-ffi") - || (matches!(bridge_model, BridgeModel::BindingsAbi3(_, _)) - && (interpreter.interpreter_kind.is_pypy() - || interpreter.interpreter_kind.is_graalpy()))) - && env::var_os("PYO3_CONFIG_FILE").is_none() - { - let pyo3_config = interpreter.pyo3_config_file(); - let maturin_target_dir = context.target_dir.join("maturin"); - let config_file = maturin_target_dir.join(format!( - "pyo3-config-{}-{}.{}.txt", - target_triple, interpreter.major, interpreter.minor - )); - fs::create_dir_all(&maturin_target_dir)?; - fs::write(&config_file, pyo3_config).with_context(|| { - format!( - "Failed to create pyo3 config file at '{}'", - config_file.display() - ) - })?; - let abs_config_file = config_file.normalize()?.into_path_buf(); - build_command.env("PYO3_CONFIG_FILE", abs_config_file); - } - } - - if let Some(lib_dir) = env::var_os("MATURIN_PYTHON_SYSCONFIGDATA_DIR") { - build_command.env("PYO3_CROSS_LIB_DIR", lib_dir); - } - - // Set default macOS deployment target version for non-editable builds - if !context.editable && target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() { - use crate::build_context::rustc_macosx_target_version; - - let target_config = context - .pyproject_toml - .as_ref() - .and_then(|x| x.target_config(target_triple)); - let deployment_target = if let Some(deployment_target) = target_config - .as_ref() - .and_then(|config| config.macos_deployment_target.as_ref()) - { - eprintln!( - "💻 Using `MACOSX_DEPLOYMENT_TARGET={deployment_target}` for {target_triple} by configuration" - ); - deployment_target.clone() - } else { - let (major, minor) = rustc_macosx_target_version(target_triple); - eprintln!( - "💻 Using `MACOSX_DEPLOYMENT_TARGET={major}.{minor}` for {target_triple} by default" - ); - format!("{major}.{minor}") - }; - build_command.env("MACOSX_DEPLOYMENT_TARGET", deployment_target); - } - Ok(build_command) -} - -fn compile_target( - context: &BuildContext, - mut build_command: Command, -) -> Result> { - debug!("Running {:?}", build_command); - - let using_cross = build_command - .get_program() - .to_string_lossy() - .starts_with("cross"); - let mut cargo_build = build_command - .spawn() - .context("Failed to run `cargo rustc`")?; - - let mut artifacts = HashMap::new(); - let mut linked_paths = Vec::new(); - - let stream = cargo_build - .stdout - .take() - .expect("Cargo build should have a stdout"); - for message in cargo_metadata::Message::parse_stream(BufReader::new(stream)) { - let message = message.context("Failed to parse cargo metadata message")?; - trace!("cargo message: {:?}", message); - match message { - cargo_metadata::Message::CompilerArtifact(artifact) => { - let package_in_metadata = context - .cargo_metadata - .packages - .iter() - .find(|package| package.id == artifact.package_id); - let crate_name = match package_in_metadata { - Some(package) => &package.name, - None => { - let package_id = &artifact.package_id; - // Ignore the package if it's coming from Rust sysroot when compiling with `-Zbuild-std` - let should_warn = !package_id.repr.contains("rustup") - && !package_id.repr.contains("rustlib") - && !artifact.features.contains(&"rustc-dep-of-std".to_string()); - if should_warn { - // This is a spurious error I don't really understand - eprintln!( - "⚠️ Warning: The package {package_id} wasn't listed in `cargo metadata`" - ); - } - continue; - } - }; - - // Extract the location of the .so/.dll/etc. from cargo's json output - if crate_name == &context.crate_name { - let tuples = artifact - .target - .crate_types - .into_iter() - .zip(artifact.filenames); - for (crate_type, filename) in tuples { - let path = if using_cross && filename.starts_with("/target") { - // Convert cross target path in docker back to path on host - context - .cargo_metadata - .target_directory - .join(filename.strip_prefix("/target").unwrap()) - .into_std_path_buf() - } else { - filename.into() - }; - let artifact = BuildArtifact { - path, - linked_paths: Vec::new(), - }; - artifacts.insert(crate_type, artifact); - } - } - } - // See https://doc.rust-lang.org/cargo/reference/external-tools.html#build-script-output - cargo_metadata::Message::BuildScriptExecuted(msg) => { - for path in msg.linked_paths.iter().map(|p| p.as_str()) { - // `linked_paths` may include a "KIND=" prefix in the string where KIND is the library kind - if let Some(index) = path.find('=') { - linked_paths.push(path[index + 1..].to_string()); - } else { - linked_paths.push(path.to_string()); - } - } - } - cargo_metadata::Message::CompilerMessage(msg) => { - println!("{}", msg.message); - } - _ => (), - } - } - - // Add linked_paths to build artifacts - for artifact in artifacts.values_mut() { - artifact.linked_paths.clone_from(&linked_paths); - } - - let status = cargo_build - .wait() - .expect("Failed to wait on cargo child process"); - - if !status.success() { - bail!( - r#"Cargo build finished with "{}": `{:?}`"#, - status, - build_command, - ) - } - - Ok(artifacts) -} - -/// Checks that the native library contains a function called `PyInit_` and warns -/// if it's missing. -/// -/// That function is the python's entrypoint for loading native extensions, i.e. python will fail -/// to import the module with error if it's missing or named incorrectly -/// -/// Currently the check is only run on linux, macOS and Windows -#[instrument(skip_all)] -pub fn warn_missing_py_init(artifact: &Path, module_name: &str) -> Result<()> { - let py_init = format!("PyInit_{module_name}"); - let mut fd = File::open(artifact)?; - let mut buffer = Vec::new(); - fd.read_to_end(&mut buffer)?; - let mut found = false; - match goblin::Object::parse(&buffer)? { - goblin::Object::Elf(elf) => { - for dyn_sym in elf.dynsyms.iter() { - if py_init == elf.dynstrtab[dyn_sym.st_name] { - found = true; - break; - } - } - } - goblin::Object::Mach(mach) => { - match mach { - goblin::mach::Mach::Binary(macho) => { - for sym in macho.exports()? { - let sym_name = sym.name; - if py_init == sym_name.strip_prefix('_').unwrap_or(&sym_name) { - found = true; - break; - } - } - if !found { - for sym in macho.symbols() { - let (sym_name, _) = sym?; - if py_init == sym_name.strip_prefix('_').unwrap_or(sym_name) { - found = true; - break; - } - } - } - } - goblin::mach::Mach::Fat(_) => { - // Ignore fat macho, - // we only generate them by combining thin binaries which is handled above - found = true - } - } - } - goblin::Object::PE(pe) => { - for sym in &pe.exports { - if let Some(sym_name) = sym.name { - if py_init == sym_name { - found = true; - break; - } - } - } - } - _ => { - // Currently, only linux, macOS and Windows are implemented - found = true - } - } - - if !found { - eprintln!( - "⚠️ Warning: Couldn't find the symbol `{py_init}` in the native library. \ - Python will fail to import this module. \ - If you're using pyo3, check that `#[pymodule]` uses `{module_name}` as module name" - ) - } - - Ok(()) -} - -fn pyo3_version(cargo_metadata: &cargo_metadata::Metadata) -> Option<(u64, u64, u64)> { - let packages: HashMap<&str, &cargo_metadata::Package> = cargo_metadata - .packages - .iter() - .filter_map(|pkg| { - let name = &pkg.name; - if name == "pyo3" || name == "pyo3-ffi" { - Some((name.as_ref(), pkg)) - } else { - None - } - }) - .collect(); - packages - .get("pyo3") - .or_else(|| packages.get("pyo3-ffi")) - .map(|pkg| (pkg.version.major, pkg.version.minor, pkg.version.patch)) -} +use crate::build_context::BridgeModel; +use crate::target::RUST_1_64_0; +#[cfg(feature = "zig")] +use crate::PlatformTag; +use crate::{BuildContext, PythonInterpreter, Target}; +use anyhow::{anyhow, bail, Context, Result}; +use cargo_metadata::CrateType; +use fat_macho::FatWriter; +use fs_err::{self as fs, File}; +use normpath::PathExt; +use std::collections::HashMap; +use std::env; +use std::io::{BufReader, Read}; +use std::path::{Path, PathBuf}; +use std::process::{Command, Stdio}; +use std::str; +use tracing::{debug, instrument, trace}; + +/// The first version of pyo3 that supports building Windows abi3 wheel +/// without `PYO3_NO_PYTHON` environment variable +const PYO3_ABI3_NO_PYTHON_VERSION: (u64, u64, u64) = (0, 16, 4); + +/// crate types excluding `bin`, `cdylib` and `proc-macro` +pub(crate) const LIB_CRATE_TYPES: [CrateType; 4] = [ + CrateType::Lib, + CrateType::DyLib, + CrateType::RLib, + CrateType::StaticLib, +]; + +/// A cargo target to build +#[derive(Debug, Clone)] +pub struct CompileTarget { + /// The cargo target to build + pub target: cargo_metadata::Target, + /// The bridge model to use + pub bridge_model: BridgeModel, +} + +/// A cargo build artifact +#[derive(Debug, Clone)] +pub struct BuildArtifact { + /// Path to the build artifact + pub path: PathBuf, + /// Array of paths to include in the library search path, as indicated by + /// the `cargo:rustc-link-search` instruction. + pub linked_paths: Vec, +} + +/// Builds the rust crate into a native module (i.e. an .so or .dll) for a +/// specific python version. Returns a mapping from crate type (e.g. cdylib) +/// to artifact location. +pub fn compile( + context: &BuildContext, + python_interpreter: Option<&PythonInterpreter>, + targets: &[CompileTarget], +) -> Result>> { + if context.universal2 { + compile_universal2(context, python_interpreter, targets) + } else { + compile_targets(context, python_interpreter, targets) + } +} + +/// Build an universal2 wheel for macos which contains both an x86 and an aarch64 binary +fn compile_universal2( + context: &BuildContext, + python_interpreter: Option<&PythonInterpreter>, + targets: &[CompileTarget], +) -> Result>> { + let mut aarch64_context = context.clone(); + aarch64_context.target = Target::from_target_triple(Some("aarch64-apple-darwin".to_string()))?; + + let aarch64_artifacts = compile_targets(&aarch64_context, python_interpreter, targets) + .context("Failed to build a aarch64 library through cargo")?; + let mut x86_64_context = context.clone(); + x86_64_context.target = Target::from_target_triple(Some("x86_64-apple-darwin".to_string()))?; + + let x86_64_artifacts = compile_targets(&x86_64_context, python_interpreter, targets) + .context("Failed to build a x86_64 library through cargo")?; + + let mut universal_artifacts = Vec::with_capacity(targets.len()); + for (bridge_model, (aarch64_artifact, x86_64_artifact)) in targets + .iter() + .map(|target| &target.bridge_model) + .zip(aarch64_artifacts.iter().zip(&x86_64_artifacts)) + { + let build_type = if bridge_model.is_bin() { + CrateType::Bin + } else { + CrateType::CDyLib + }; + let aarch64_artifact = aarch64_artifact.get(&build_type).cloned().ok_or_else(|| { + if build_type == CrateType::CDyLib { + anyhow!( + "Cargo didn't build an aarch64 cdylib. Did you miss crate-type = [\"cdylib\"] \ + in the lib section of your Cargo.toml?", + ) + } else { + anyhow!("Cargo didn't build an aarch64 bin.") + } + })?; + let x86_64_artifact = x86_64_artifact.get(&build_type).cloned().ok_or_else(|| { + if build_type == CrateType::CDyLib { + anyhow!( + "Cargo didn't build a x86_64 cdylib. Did you miss crate-type = [\"cdylib\"] \ + in the lib section of your Cargo.toml?", + ) + } else { + anyhow!("Cargo didn't build a x86_64 bin.") + } + })?; + // Create an universal dylib + let output_path = aarch64_artifact + .path + .display() + .to_string() + .replace("aarch64-apple-darwin/", ""); + let mut writer = FatWriter::new(); + let aarch64_file = fs::read(&aarch64_artifact.path)?; + let x86_64_file = fs::read(&x86_64_artifact.path)?; + writer + .add(aarch64_file) + .map_err(|e| anyhow!("Failed to add aarch64 cdylib: {:?}", e))?; + writer + .add(x86_64_file) + .map_err(|e| anyhow!("Failed to add x86_64 cdylib: {:?}", e))?; + writer + .write_to_file(&output_path) + .map_err(|e| anyhow!("Failed to create universal cdylib: {:?}", e))?; + + let mut result = HashMap::new(); + let universal_artifact = BuildArtifact { + path: PathBuf::from(output_path), + ..x86_64_artifact + }; + result.insert(build_type, universal_artifact); + universal_artifacts.push(result); + } + Ok(universal_artifacts) +} + +fn compile_targets( + context: &BuildContext, + python_interpreter: Option<&PythonInterpreter>, + targets: &[CompileTarget], +) -> Result>> { + let mut artifacts = Vec::with_capacity(targets.len()); + for target in targets { + let build_command = cargo_build_command(context, python_interpreter, target)?; + artifacts.push(compile_target(context, build_command)?); + } + Ok(artifacts) +} + +fn cargo_build_command( + context: &BuildContext, + python_interpreter: Option<&PythonInterpreter>, + compile_target: &CompileTarget, +) -> Result { + let target = &context.target; + + let mut cargo_rustc: cargo_options::Rustc = context.cargo_options.clone().into(); + cargo_rustc.message_format = vec!["json-render-diagnostics".to_string()]; + + // --release and --profile are conflicting options + if context.release && cargo_rustc.profile.is_none() { + cargo_rustc.release = true; + } + + // Add `--crate-type cdylib` if available + if compile_target + .target + .crate_types + .iter() + .any(|crate_type| LIB_CRATE_TYPES.contains(crate_type)) + { + // `--crate-type` is stable since Rust 1.64.0 + // See https://github.com/rust-lang/cargo/pull/10838 + if target.rustc_version.semver >= RUST_1_64_0 { + debug!("Setting crate_type to cdylib for Rust >= 1.64.0"); + cargo_rustc.crate_type = vec!["cdylib".to_string()]; + } + } + + let target_triple = target.target_triple(); + + let manifest_dir = context.manifest_path.parent().unwrap(); + let mut rustflags = cargo_config2::Config::load_with_cwd(manifest_dir)? + .rustflags(target_triple)? + .unwrap_or_default(); + let original_rustflags = rustflags.flags.clone(); + + // We need to pass --bin / --lib + let bridge_model = &compile_target.bridge_model; + match bridge_model { + BridgeModel::Bin(..) => { + cargo_rustc.bin.push(compile_target.target.name.clone()); + } + BridgeModel::Cffi + | BridgeModel::UniFfi + | BridgeModel::Bindings { .. } + | BridgeModel::BindingsAbi3(..) => { + cargo_rustc.lib = true; + // https://github.com/rust-lang/rust/issues/59302#issue-422994250 + // We must only do this for libraries as it breaks binaries + // For some reason this value is ignored when passed as rustc argument + if context.target.is_musl_libc() + && !rustflags + .flags + .iter() + .any(|f| f == "target-feature=-crt-static") + { + debug!("Setting `-C target-features=-crt-static` for musl dylib"); + rustflags.push("-C"); + rustflags.push("target-feature=-crt-static"); + } + } + } + + // https://github.com/PyO3/pyo3/issues/88#issuecomment-337744403 + if target.is_macos() { + if let BridgeModel::Bindings { .. } | BridgeModel::BindingsAbi3(..) = bridge_model { + // Change LC_ID_DYLIB to the final .so name for macOS targets to avoid linking with + // non-existent library. + // See https://github.com/PyO3/setuptools-rust/issues/106 for detail + let module_name = &context.module_name; + let so_filename = match bridge_model { + BridgeModel::BindingsAbi3(..) => format!("{module_name}.abi3.so"), + _ => python_interpreter + .expect("missing python interpreter for non-abi3 wheel build") + .get_library_name(module_name), + }; + let macos_dylib_install_name = + format!("link-args=-Wl,-install_name,@rpath/{so_filename}"); + let mac_args = [ + "-C".to_string(), + "link-arg=-undefined".to_string(), + "-C".to_string(), + "link-arg=dynamic_lookup".to_string(), + "-C".to_string(), + macos_dylib_install_name, + ]; + debug!("Setting additional linker args for macOS: {:?}", mac_args); + cargo_rustc.args.extend(mac_args); + } + } else if target.is_emscripten() { + // Allow user to override these default flags + if !rustflags + .flags + .iter() + .any(|f| f.contains("link-native-libraries")) + { + debug!("Setting `-Z link-native-libraries=no` for Emscripten"); + rustflags.push("-Z"); + rustflags.push("link-native-libraries=no"); + } + let mut emscripten_args = Vec::new(); + // Allow user to override these default settings + if !cargo_rustc + .args + .iter() + .any(|arg| arg.contains("SIDE_MODULE")) + { + emscripten_args.push("-C".to_string()); + emscripten_args.push("link-arg=-sSIDE_MODULE=2".to_string()); + } + if !cargo_rustc + .args + .iter() + .any(|arg| arg.contains("WASM_BIGINT")) + { + emscripten_args.push("-C".to_string()); + emscripten_args.push("link-arg=-sWASM_BIGINT".to_string()); + } + debug!( + "Setting additional linker args for Emscripten: {:?}", + emscripten_args + ); + cargo_rustc.args.extend(emscripten_args); + } + + if context.strip { + // https://doc.rust-lang.org/rustc/codegen-options/index.html#strip + cargo_rustc + .args + .extend(["-C".to_string(), "strip=symbols".to_string()]); + } + + let mut build_command = if target.is_msvc() && target.cross_compiling() { + #[cfg(feature = "xwin")] + { + // Don't use xwin if the Windows MSVC compiler can compile to the target + let native_compile = cc::Build::new() + .opt_level(0) + .host(target.host_triple()) + .target(target_triple) + .cargo_metadata(false) + .cargo_warnings(false) + .cargo_output(false) + .try_get_compiler() + .is_ok(); + let force_xwin = env::var("MATURIN_USE_XWIN").ok().as_deref() == Some("1"); + if !native_compile || force_xwin { + println!("🛠️ Using xwin for cross-compiling to {target_triple}"); + let xwin_options = { + use clap::Parser; + + // This will populate the default values for the options + // and then override them with cargo-xwin environment variables. + cargo_xwin::XWinOptions::parse_from(Vec::<&str>::new()) + }; + + let mut build = cargo_xwin::Rustc::from(cargo_rustc); + build.target = vec![target_triple.to_string()]; + build.xwin = xwin_options; + build.build_command()? + } else { + if target.user_specified { + cargo_rustc.target = vec![target_triple.to_string()]; + } + cargo_rustc.command() + } + } + #[cfg(not(feature = "xwin"))] + { + if target.user_specified { + cargo_rustc.target = vec![target_triple.to_string()]; + } + cargo_rustc.command() + } + } else { + #[cfg(feature = "zig")] + { + let mut build = cargo_zigbuild::Rustc::from(cargo_rustc); + if !context.zig { + build.disable_zig_linker = true; + if target.user_specified { + build.target = vec![target_triple.to_string()]; + } + } else { + println!("🛠️ Using zig for cross-compiling to {target_triple}"); + build.enable_zig_ar = true; + let zig_triple = if target.is_linux() && !target.is_musl_libc() { + match context.platform_tag.iter().find(|tag| tag.is_manylinux()) { + Some(PlatformTag::Manylinux { x, y }) => { + format!("{target_triple}.{x}.{y}") + } + _ => target_triple.to_string(), + } + } else { + target_triple.to_string() + }; + build.target = vec![zig_triple]; + } + build.build_command()? + } + #[cfg(not(feature = "zig"))] + { + if target.user_specified { + cargo_rustc.target = vec![target_triple.to_string()]; + } + cargo_rustc.command() + } + }; + + #[cfg(feature = "zig")] + if context.zig { + // Pass zig command to downstream, eg. python3-dll-a + if let Ok((zig_cmd, zig_args)) = cargo_zigbuild::Zig::find_zig() { + if zig_args.is_empty() { + build_command.env("ZIG_COMMAND", zig_cmd); + } else { + build_command.env( + "ZIG_COMMAND", + format!("{} {}", zig_cmd.display(), zig_args.join(" ")), + ); + }; + } + } + + build_command + // We need to capture the json messages + .stdout(Stdio::piped()) + // We can't get colored human and json messages from rustc as they are mutually exclusive, + // but forwarding stderr is still useful in case there some non-json error + .stderr(Stdio::inherit()); + + if !rustflags.flags.is_empty() && rustflags.flags != original_rustflags { + build_command.env("CARGO_ENCODED_RUSTFLAGS", rustflags.encode()?); + } + + if let BridgeModel::BindingsAbi3(_, _) = bridge_model { + let is_pypy_or_graalpy = python_interpreter + .map(|p| p.interpreter_kind.is_pypy() || p.interpreter_kind.is_graalpy()) + .unwrap_or(false); + if !is_pypy_or_graalpy && !target.is_windows() { + let pyo3_ver = pyo3_version(&context.cargo_metadata) + .context("Failed to get pyo3 version from cargo metadata")?; + if pyo3_ver < PYO3_ABI3_NO_PYTHON_VERSION { + // This will make old pyo3's build script only set some predefined linker + // arguments without trying to read any python configuration + build_command.env("PYO3_NO_PYTHON", "1"); + } + } + } + + // Setup `PYO3_CONFIG_FILE` if we are cross compiling for pyo3 bindings + if let Some(interpreter) = python_interpreter { + // Target python interpreter isn't runnable when cross compiling + if interpreter.runnable { + if bridge_model.is_bindings("pyo3") + || bridge_model.is_bindings("pyo3-ffi") + || matches!(bridge_model, BridgeModel::BindingsAbi3(_, _)) + { + debug!( + "Setting PYO3_PYTHON to {}", + interpreter.executable.display() + ); + build_command + .env("PYO3_PYTHON", &interpreter.executable) + .env( + "PYO3_ENVIRONMENT_SIGNATURE", + interpreter.environment_signature(), + ); + } + + // rust-cpython, and legacy pyo3 versions + build_command.env("PYTHON_SYS_EXECUTABLE", &interpreter.executable); + } else if (bridge_model.is_bindings("pyo3") + || bridge_model.is_bindings("pyo3-ffi") + || (matches!(bridge_model, BridgeModel::BindingsAbi3(_, _)) + && (interpreter.interpreter_kind.is_pypy() + || interpreter.interpreter_kind.is_graalpy()))) + && env::var_os("PYO3_CONFIG_FILE").is_none() + { + let pyo3_config = interpreter.pyo3_config_file(); + let maturin_target_dir = context.target_dir.join("maturin"); + let config_file = maturin_target_dir.join(format!( + "pyo3-config-{}-{}.{}.txt", + target_triple, interpreter.major, interpreter.minor + )); + fs::create_dir_all(&maturin_target_dir)?; + fs::write(&config_file, pyo3_config).with_context(|| { + format!( + "Failed to create pyo3 config file at '{}'", + config_file.display() + ) + })?; + let abs_config_file = config_file.normalize()?.into_path_buf(); + build_command.env("PYO3_CONFIG_FILE", abs_config_file); + } + } + + if let Some(lib_dir) = env::var_os("MATURIN_PYTHON_SYSCONFIGDATA_DIR") { + build_command.env("PYO3_CROSS_LIB_DIR", lib_dir); + } + + // Set default macOS deployment target version for non-editable builds + if !context.editable && target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() { + use crate::build_context::rustc_macosx_target_version; + + let target_config = context + .pyproject_toml + .as_ref() + .and_then(|x| x.target_config(target_triple)); + let deployment_target = if let Some(deployment_target) = target_config + .as_ref() + .and_then(|config| config.macos_deployment_target.as_ref()) + { + eprintln!( + "💻 Using `MACOSX_DEPLOYMENT_TARGET={deployment_target}` for {target_triple} by configuration" + ); + deployment_target.clone() + } else { + let (major, minor) = rustc_macosx_target_version(target_triple); + eprintln!( + "💻 Using `MACOSX_DEPLOYMENT_TARGET={major}.{minor}` for {target_triple} by default" + ); + format!("{major}.{minor}") + }; + build_command.env("MACOSX_DEPLOYMENT_TARGET", deployment_target); + } + Ok(build_command) +} + +fn compile_target( + context: &BuildContext, + mut build_command: Command, +) -> Result> { + debug!("Running {:?}", build_command); + + let using_cross = build_command + .get_program() + .to_string_lossy() + .starts_with("cross"); + let mut cargo_build = build_command + .spawn() + .context("Failed to run `cargo rustc`")?; + + let mut artifacts = HashMap::new(); + let mut linked_paths = Vec::new(); + + let stream = cargo_build + .stdout + .take() + .expect("Cargo build should have a stdout"); + for message in cargo_metadata::Message::parse_stream(BufReader::new(stream)) { + let message = message.context("Failed to parse cargo metadata message")?; + trace!("cargo message: {:?}", message); + match message { + cargo_metadata::Message::CompilerArtifact(artifact) => { + let package_in_metadata = context + .cargo_metadata + .packages + .iter() + .find(|package| package.id == artifact.package_id); + let crate_name = match package_in_metadata { + Some(package) => &package.name, + None => { + let package_id = &artifact.package_id; + // Ignore the package if it's coming from Rust sysroot when compiling with `-Zbuild-std` + let should_warn = !package_id.repr.contains("rustup") + && !package_id.repr.contains("rustlib") + && !artifact.features.contains(&"rustc-dep-of-std".to_string()); + if should_warn { + // This is a spurious error I don't really understand + eprintln!( + "⚠️ Warning: The package {package_id} wasn't listed in `cargo metadata`" + ); + } + continue; + } + }; + + // Extract the location of the .so/.dll/etc. from cargo's json output + if crate_name == &context.crate_name { + let tuples = artifact + .target + .crate_types + .into_iter() + .zip(artifact.filenames); + for (crate_type, filename) in tuples { + let path = if using_cross && filename.starts_with("/target") { + // Convert cross target path in docker back to path on host + context + .cargo_metadata + .target_directory + .join(filename.strip_prefix("/target").unwrap()) + .into_std_path_buf() + } else { + filename.into() + }; + let artifact = BuildArtifact { + path, + linked_paths: Vec::new(), + }; + artifacts.insert(crate_type, artifact); + } + } + } + // See https://doc.rust-lang.org/cargo/reference/external-tools.html#build-script-output + cargo_metadata::Message::BuildScriptExecuted(msg) => { + for path in msg.linked_paths.iter().map(|p| p.as_str()) { + // `linked_paths` may include a "KIND=" prefix in the string where KIND is the library kind + if let Some(index) = path.find('=') { + linked_paths.push(path[index + 1..].to_string()); + } else { + linked_paths.push(path.to_string()); + } + } + } + cargo_metadata::Message::CompilerMessage(msg) => { + println!("{}", msg.message); + } + _ => (), + } + } + + // Add linked_paths to build artifacts + for artifact in artifacts.values_mut() { + artifact.linked_paths.clone_from(&linked_paths); + } + + let status = cargo_build + .wait() + .expect("Failed to wait on cargo child process"); + + if !status.success() { + bail!( + r#"Cargo build finished with "{}": `{:?}`"#, + status, + build_command, + ) + } + + Ok(artifacts) +} + +/// Checks that the native library contains a function called `PyInit_` and warns +/// if it's missing. +/// +/// That function is the python's entrypoint for loading native extensions, i.e. python will fail +/// to import the module with error if it's missing or named incorrectly +/// +/// Currently the check is only run on linux, macOS and Windows +#[instrument(skip_all)] +pub fn warn_missing_py_init(artifact: &Path, module_name: &str) -> Result<()> { + let py_init = format!("PyInit_{module_name}"); + let mut fd = File::open(artifact)?; + let mut buffer = Vec::new(); + fd.read_to_end(&mut buffer)?; + let mut found = false; + match goblin::Object::parse(&buffer)? { + goblin::Object::Elf(elf) => { + for dyn_sym in elf.dynsyms.iter() { + if py_init == elf.dynstrtab[dyn_sym.st_name] { + found = true; + break; + } + } + } + goblin::Object::Mach(mach) => { + match mach { + goblin::mach::Mach::Binary(macho) => { + for sym in macho.exports()? { + let sym_name = sym.name; + if py_init == sym_name.strip_prefix('_').unwrap_or(&sym_name) { + found = true; + break; + } + } + if !found { + for sym in macho.symbols() { + let (sym_name, _) = sym?; + if py_init == sym_name.strip_prefix('_').unwrap_or(sym_name) { + found = true; + break; + } + } + } + } + goblin::mach::Mach::Fat(_) => { + // Ignore fat macho, + // we only generate them by combining thin binaries which is handled above + found = true + } + } + } + goblin::Object::PE(pe) => { + for sym in &pe.exports { + if let Some(sym_name) = sym.name { + if py_init == sym_name { + found = true; + break; + } + } + } + } + _ => { + // Currently, only linux, macOS and Windows are implemented + found = true + } + } + + if !found { + eprintln!( + "⚠️ Warning: Couldn't find the symbol `{py_init}` in the native library. \ + Python will fail to import this module. \ + If you're using pyo3, check that `#[pymodule]` uses `{module_name}` as module name" + ) + } + + Ok(()) +} + +fn pyo3_version(cargo_metadata: &cargo_metadata::Metadata) -> Option<(u64, u64, u64)> { + let packages: HashMap<&str, &cargo_metadata::Package> = cargo_metadata + .packages + .iter() + .filter_map(|pkg| { + let name = &pkg.name; + if name == "pyo3" || name == "pyo3-ffi" { + Some((name.as_ref(), pkg)) + } else { + None + } + }) + .collect(); + packages + .get("pyo3") + .or_else(|| packages.get("pyo3-ffi")) + .map(|pkg| (pkg.version.major, pkg.version.minor, pkg.version.patch)) +} diff --git a/src/cross_compile.rs b/src/cross_compile.rs index 3b62a7233..d34d5e000 100644 --- a/src/cross_compile.rs +++ b/src/cross_compile.rs @@ -1,220 +1,205 @@ -use crate::{PythonInterpreter, Target}; -use anyhow::{bail, Result}; -use fs_err::{self as fs, DirEntry}; -use normpath::PathExt as _; -use std::collections::HashMap; -use std::env; -use std::path::{Path, PathBuf}; - -pub fn is_cross_compiling(target: &Target) -> Result { - let target_triple = target.target_triple(); - let host = target.host_triple(); - if target_triple == host { - // Not cross-compiling - return Ok(false); - } - - if target_triple == "x86_64-apple-darwin" && host == "aarch64-apple-darwin" { - // Not cross-compiling to compile for x86-64 Python from macOS arm64 - return Ok(false); - } - if target_triple == "aarch64-apple-darwin" && host == "x86_64-apple-darwin" { - // Not cross-compiling to compile for arm64 Python from macOS x86_64 - return Ok(false); - } - - if target_triple.starts_with("i686-pc-windows") && host.starts_with("x86_64-pc-windows") { - // Not cross-compiling to compile for 32-bit Python from windows 64-bit - return Ok(false); - } - if (target_triple == "aarch64-pc-windows-msvc" && host == "x86_64-pc-windows-msvc") - || (target_triple == "x86_64-pc-windows-msvc" && host == "aarch64-pc-windows-msvc") - { - // Not cross-compiling if the Windows MSVC compiler can compile to the target - let native_compile = cc::Build::new() - .opt_level(0) - .host(host) - .target(target_triple) - .cargo_metadata(false) - .cargo_warnings(false) - .cargo_output(false) - .try_get_compiler() - .is_ok(); - return Ok(!native_compile); - } - if target_triple.ends_with("windows-gnu") && host.ends_with("windows-msvc") { - // Not cross-compiling to compile for Windows GNU from Windows MSVC host - return Ok(false); - } - - Ok(true) -} - -/// Parse sysconfigdata file -/// -/// The sysconfigdata is simply a dictionary containing all the build time variables used for the -/// python executable and library. Here it is read and added to a script to extract only what is -/// necessary. This necessitates a python interpreter for the host machine to work. -pub fn parse_sysconfigdata( - interpreter: &PythonInterpreter, - config_path: impl AsRef, -) -> Result> { - let mut script = fs::read_to_string(config_path)?; - script += r#" -print("version_major", build_time_vars["VERSION"][0]) # 3 -print("version_minor", build_time_vars["VERSION"][2:]) # E.g., 8, 10 -KEYS = [ - "ABIFLAGS", - "EXT_SUFFIX", - "SOABI", - "Py_GIL_DISABLED", -] -for key in KEYS: - print(key, build_time_vars.get(key, "")) -"#; - let output = interpreter.run_script(&script)?; - - Ok(parse_script_output(&output)) -} - -fn parse_script_output(output: &str) -> HashMap { - output - .lines() - .filter_map(|line| { - line.split_once(' ') - .map(|(x, y)| (x.to_string(), y.to_string())) - }) - .collect() -} - -fn starts_with(entry: &DirEntry, pat: &str) -> bool { - let name = entry.file_name(); - name.to_string_lossy().starts_with(pat) -} -fn ends_with(entry: &DirEntry, pat: &str) -> bool { - let name = entry.file_name(); - name.to_string_lossy().ends_with(pat) -} - -/// Finds the `_sysconfigdata*.py` file in the library path. -/// -/// From the python source for `_sysconfigdata*.py` is always going to be located at -/// `build/lib.{PLATFORM}-{PY_MINOR_VERSION}` when built from source. The [exact line][1] is defined as: -/// -/// ```py -/// pybuilddir = 'build/lib.%s-%s' % (get_platform(), sys.version_info[:2]) -/// ``` -/// -/// Where get_platform returns a kebab-case formatted string containing the os, the architecture and -/// possibly the os' kernel version (not the case on linux). However, when installed using a package -/// manager, the `_sysconfigdata*.py` file is installed in the `${PREFIX}/lib/python3.Y/` directory. -/// The `_sysconfigdata*.py` is generally in a sub-directory of the location of `libpython3.Y.so`. -/// So we must find the file in the following possible locations: -/// -/// ```sh -/// # distribution from package manager, lib_dir should include lib/ -/// ${INSTALL_PREFIX}/lib/python3.Y/_sysconfigdata*.py -/// ${INSTALL_PREFIX}/lib/libpython3.Y.so -/// ${INSTALL_PREFIX}/lib/python3.Y/config-3.Y-${HOST_TRIPLE}/libpython3.Y.so -/// -/// # Built from source from host -/// ${CROSS_COMPILED_LOCATION}/build/lib.linux-x86_64-Y/_sysconfigdata*.py -/// ${CROSS_COMPILED_LOCATION}/libpython3.Y.so -/// -/// # if cross compiled, kernel release is only present on certain OS targets. -/// ${CROSS_COMPILED_LOCATION}/build/lib.{OS}(-{OS-KERNEL-RELEASE})?-{ARCH}-Y/_sysconfigdata*.py -/// ${CROSS_COMPILED_LOCATION}/libpython3.Y.so -/// ``` -/// -/// [1]: https://github.com/python/cpython/blob/3.5/Lib/sysconfig.py#L389 -pub fn find_sysconfigdata(lib_dir: &Path, target: &Target) -> Result { - let sysconfig_paths = search_lib_dir(lib_dir, target)?; - let sysconfig_name = env::var_os("_PYTHON_SYSCONFIGDATA_NAME"); - let mut sysconfig_paths = sysconfig_paths - .iter() - .filter_map(|p| { - let canonical = p.normalize().ok().map(|p| p.into_path_buf()); - match &sysconfig_name { - Some(_) => canonical.filter(|p| p.file_stem() == sysconfig_name.as_deref()), - None => canonical, - } - }) - .collect::>(); - sysconfig_paths.dedup(); - if sysconfig_paths.is_empty() { - bail!("Could not find _sysconfigdata*.py in {}", lib_dir.display()); - } else if sysconfig_paths.len() > 1 { - bail!( - "Detected multiple possible python versions, please set the PYO3_PYTHON_VERSION \ - variable to the wanted version on your system or set the _PYTHON_SYSCONFIGDATA_NAME \ - variable to the wanted sysconfigdata file name\nsysconfigdata paths = {:?}", - sysconfig_paths - ) - } - - Ok(sysconfig_paths.remove(0)) -} - -/// recursive search for _sysconfigdata, returns all possibilities of sysconfigdata paths -fn search_lib_dir(path: impl AsRef, target: &Target) -> Result> { - let mut sysconfig_paths = vec![]; - let (cpython_version_pat, pypy_version_pat) = if let Some(v) = - env::var_os("PYO3_CROSS_PYTHON_VERSION").map(|s| s.into_string().unwrap()) - { - (format!("python{v}"), format!("pypy{v}")) - } else { - ("python3.".into(), "pypy3.".into()) - }; - for f in fs::read_dir(path.as_ref())? { - let sysc = match &f { - Ok(f) if starts_with(f, "_sysconfigdata") && ends_with(f, "py") => vec![f.path()], - Ok(f) if starts_with(f, "build") => search_lib_dir(f.path(), target)?, - Ok(f) if starts_with(f, "lib.") => { - let name = f.file_name(); - // check if right target os - if !name.to_string_lossy().contains(target.get_python_os()) { - continue; - } - // Check if right arch - if !name - .to_string_lossy() - .contains(&target.target_arch().to_string()) - { - continue; - } - search_lib_dir(f.path(), target)? - } - Ok(f) if starts_with(f, &cpython_version_pat) => search_lib_dir(f.path(), target)?, - // PyPy 3.7: /opt/python/pp37-pypy37_pp73/lib_pypy/_sysconfigdata__linux_x86_64-linux-gnu.py - Ok(f) if starts_with(f, "lib_pypy") => search_lib_dir(f.path(), target)?, - // PyPy 3.8: /opt/python/pp38-pypy38_pp73/lib/pypy3.8/_sysconfigdata__linux_x86_64-linux-gnu.py - Ok(f) if starts_with(f, &pypy_version_pat) => search_lib_dir(f.path(), target)?, - Ok(f) if starts_with(f, "lib") && f.path().is_dir() => { - search_lib_dir(f.path(), target)? - } - _ => continue, - }; - sysconfig_paths.extend(sysc); - } - // If we got more than one file, only take those that contain the arch name. - // For ubuntu 20.04 with host architecture x86_64 and a foreign architecture of armhf - // this reduces the number of candidates to 1: - // - // $ find /usr/lib/python3.8/ -name '_sysconfigdata*.py' -not -lname '*' - // /usr/lib/python3.8/_sysconfigdata__x86_64-linux-gnu.py - // /usr/lib/python3.8/_sysconfigdata__arm-linux-gnueabihf.py - if sysconfig_paths.len() > 1 { - let temp = sysconfig_paths - .iter() - .filter(|p| { - p.to_string_lossy() - .contains(&target.target_arch().to_string()) - }) - .cloned() - .collect::>(); - if !temp.is_empty() { - sysconfig_paths = temp; - } - } - Ok(sysconfig_paths) -} +use crate::{PythonInterpreter, Target}; +use anyhow::{bail, Result}; +use fs_err::{self as fs, DirEntry}; +use normpath::PathExt as _; +use std::collections::HashMap; +use std::env; +use std::path::{Path, PathBuf}; + +pub fn is_cross_compiling(target: &Target) -> Result { + let target_triple = target.target_triple(); + let host = target.host_triple(); + if target_triple == host { + // Not cross-compiling + return Ok(false); + } + + if target_triple == "x86_64-apple-darwin" && host == "aarch64-apple-darwin" { + // Not cross-compiling to compile for x86-64 Python from macOS arm64 + return Ok(false); + } + if target_triple == "aarch64-apple-darwin" && host == "x86_64-apple-darwin" { + // Not cross-compiling to compile for arm64 Python from macOS x86_64 + return Ok(false); + } + + if target_triple.starts_with("i686-pc-windows") && host.starts_with("x86_64-pc-windows") { + // Not cross-compiling to compile for 32-bit Python from windows 64-bit + return Ok(false); + } + if target_triple.ends_with("windows-gnu") && host.ends_with("windows-msvc") { + // Not cross-compiling to compile for Windows GNU from Windows MSVC host + return Ok(false); + } + + Ok(true) +} + +/// Parse sysconfigdata file +/// +/// The sysconfigdata is simply a dictionary containing all the build time variables used for the +/// python executable and library. Here it is read and added to a script to extract only what is +/// necessary. This necessitates a python interpreter for the host machine to work. +pub fn parse_sysconfigdata( + interpreter: &PythonInterpreter, + config_path: impl AsRef, +) -> Result> { + let mut script = fs::read_to_string(config_path)?; + script += r#" +print("version_major", build_time_vars["VERSION"][0]) # 3 +print("version_minor", build_time_vars["VERSION"][2:]) # E.g., 8, 10 +KEYS = [ + "ABIFLAGS", + "EXT_SUFFIX", + "SOABI", + "Py_GIL_DISABLED", +] +for key in KEYS: + print(key, build_time_vars.get(key, "")) +"#; + let output = interpreter.run_script(&script)?; + + Ok(parse_script_output(&output)) +} + +fn parse_script_output(output: &str) -> HashMap { + output + .lines() + .filter_map(|line| { + line.split_once(' ') + .map(|(x, y)| (x.to_string(), y.to_string())) + }) + .collect() +} + +fn starts_with(entry: &DirEntry, pat: &str) -> bool { + let name = entry.file_name(); + name.to_string_lossy().starts_with(pat) +} +fn ends_with(entry: &DirEntry, pat: &str) -> bool { + let name = entry.file_name(); + name.to_string_lossy().ends_with(pat) +} + +/// Finds the `_sysconfigdata*.py` file in the library path. +/// +/// From the python source for `_sysconfigdata*.py` is always going to be located at +/// `build/lib.{PLATFORM}-{PY_MINOR_VERSION}` when built from source. The [exact line][1] is defined as: +/// +/// ```py +/// pybuilddir = 'build/lib.%s-%s' % (get_platform(), sys.version_info[:2]) +/// ``` +/// +/// Where get_platform returns a kebab-case formatted string containing the os, the architecture and +/// possibly the os' kernel version (not the case on linux). However, when installed using a package +/// manager, the `_sysconfigdata*.py` file is installed in the `${PREFIX}/lib/python3.Y/` directory. +/// The `_sysconfigdata*.py` is generally in a sub-directory of the location of `libpython3.Y.so`. +/// So we must find the file in the following possible locations: +/// +/// ```sh +/// # distribution from package manager, lib_dir should include lib/ +/// ${INSTALL_PREFIX}/lib/python3.Y/_sysconfigdata*.py +/// ${INSTALL_PREFIX}/lib/libpython3.Y.so +/// ${INSTALL_PREFIX}/lib/python3.Y/config-3.Y-${HOST_TRIPLE}/libpython3.Y.so +/// +/// # Built from source from host +/// ${CROSS_COMPILED_LOCATION}/build/lib.linux-x86_64-Y/_sysconfigdata*.py +/// ${CROSS_COMPILED_LOCATION}/libpython3.Y.so +/// +/// # if cross compiled, kernel release is only present on certain OS targets. +/// ${CROSS_COMPILED_LOCATION}/build/lib.{OS}(-{OS-KERNEL-RELEASE})?-{ARCH}-Y/_sysconfigdata*.py +/// ${CROSS_COMPILED_LOCATION}/libpython3.Y.so +/// ``` +/// +/// [1]: https://github.com/python/cpython/blob/3.5/Lib/sysconfig.py#L389 +pub fn find_sysconfigdata(lib_dir: &Path, target: &Target) -> Result { + let sysconfig_paths = search_lib_dir(lib_dir, target)?; + let sysconfig_name = env::var_os("_PYTHON_SYSCONFIGDATA_NAME"); + let mut sysconfig_paths = sysconfig_paths + .iter() + .filter_map(|p| { + let canonical = p.normalize().ok().map(|p| p.into_path_buf()); + match &sysconfig_name { + Some(_) => canonical.filter(|p| p.file_stem() == sysconfig_name.as_deref()), + None => canonical, + } + }) + .collect::>(); + sysconfig_paths.dedup(); + if sysconfig_paths.is_empty() { + bail!("Could not find _sysconfigdata*.py in {}", lib_dir.display()); + } else if sysconfig_paths.len() > 1 { + bail!( + "Detected multiple possible python versions, please set the PYO3_PYTHON_VERSION \ + variable to the wanted version on your system or set the _PYTHON_SYSCONFIGDATA_NAME \ + variable to the wanted sysconfigdata file name\nsysconfigdata paths = {:?}", + sysconfig_paths + ) + } + + Ok(sysconfig_paths.remove(0)) +} + +/// recursive search for _sysconfigdata, returns all possibilities of sysconfigdata paths +fn search_lib_dir(path: impl AsRef, target: &Target) -> Result> { + let mut sysconfig_paths = vec![]; + let (cpython_version_pat, pypy_version_pat) = if let Some(v) = + env::var_os("PYO3_CROSS_PYTHON_VERSION").map(|s| s.into_string().unwrap()) + { + (format!("python{v}"), format!("pypy{v}")) + } else { + ("python3.".into(), "pypy3.".into()) + }; + for f in fs::read_dir(path.as_ref())? { + let sysc = match &f { + Ok(f) if starts_with(f, "_sysconfigdata") && ends_with(f, "py") => vec![f.path()], + Ok(f) if starts_with(f, "build") => search_lib_dir(f.path(), target)?, + Ok(f) if starts_with(f, "lib.") => { + let name = f.file_name(); + // check if right target os + if !name.to_string_lossy().contains(target.get_python_os()) { + continue; + } + // Check if right arch + if !name + .to_string_lossy() + .contains(&target.target_arch().to_string()) + { + continue; + } + search_lib_dir(f.path(), target)? + } + Ok(f) if starts_with(f, &cpython_version_pat) => search_lib_dir(f.path(), target)?, + // PyPy 3.7: /opt/python/pp37-pypy37_pp73/lib_pypy/_sysconfigdata__linux_x86_64-linux-gnu.py + Ok(f) if starts_with(f, "lib_pypy") => search_lib_dir(f.path(), target)?, + // PyPy 3.8: /opt/python/pp38-pypy38_pp73/lib/pypy3.8/_sysconfigdata__linux_x86_64-linux-gnu.py + Ok(f) if starts_with(f, &pypy_version_pat) => search_lib_dir(f.path(), target)?, + Ok(f) if starts_with(f, "lib") && f.path().is_dir() => { + search_lib_dir(f.path(), target)? + } + _ => continue, + }; + sysconfig_paths.extend(sysc); + } + // If we got more than one file, only take those that contain the arch name. + // For ubuntu 20.04 with host architecture x86_64 and a foreign architecture of armhf + // this reduces the number of candidates to 1: + // + // $ find /usr/lib/python3.8/ -name '_sysconfigdata*.py' -not -lname '*' + // /usr/lib/python3.8/_sysconfigdata__x86_64-linux-gnu.py + // /usr/lib/python3.8/_sysconfigdata__arm-linux-gnueabihf.py + if sysconfig_paths.len() > 1 { + let temp = sysconfig_paths + .iter() + .filter(|p| { + p.to_string_lossy() + .contains(&target.target_arch().to_string()) + }) + .cloned() + .collect::>(); + if !temp.is_empty() { + sysconfig_paths = temp; + } + } + Ok(sysconfig_paths) +} diff --git a/test-crates/pyo3-mixed/Cargo.lock b/test-crates/pyo3-mixed/Cargo.lock index a182a107d..a2084b10d 100644 --- a/test-crates/pyo3-mixed/Cargo.lock +++ b/test-crates/pyo3-mixed/Cargo.lock @@ -144,9 +144,9 @@ dependencies = [ [[package]] name = "python3-dll-a" -version = "0.2.9" +version = "0.2.11" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d5f07cd4412be8fa09a721d40007c483981bbe072cd6a21f2e83e04ec8f8343f" +checksum = "9b9e268ee1be609e93a13eb06839f68f67e5fe0fb4049834d261c2d5091c1b6d" dependencies = [ "cc", ]