Turn patchelf version warning into a hard error

PyO3 · Dec 5, 2022 · cc721e0 · cc721e0
1 parent d279f32
commit cc721e0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 * **Breaking Change**: Build with `--no-default-features` by default when bootstrapping from sdist in [#1333](https://github.com/PyO3/maturin/pull/1333)
+* **Breaking Change**: Remove deprecated `sdist-include` option in `pyproject.toml` in [#1335](https://github.com/PyO3/maturin/pull/1335)
+* **Breaking Change**: Remove deprecated `python-source` option in `Cargo.toml` in [#1335](https://github.com/PyO3/maturin/pull/1335)
+* **Breaking Change**: Turn `patchelf` version warning into a hard error in [#1335](https://github.com/PyO3/maturin/pull/1335)
 
 ## [0.14.4] - 2022-12-05
 

diff --git a/src/auditwheel/patchelf.rs b/src/auditwheel/patchelf.rs
@@ -21,9 +21,8 @@ pub fn verify_patchelf() -> Result<()> {
         .context("Failed to parse patchelf version")?;
     println!("{:?}", semver);
     if semver < semver::Version::new(0, 14, 0) {
-        // TODO: turn it into an error in 1.0
-        eprintln!(
-            "⚠️  Warning: patchelf {} found. auditwheel repair requires patchelf >= 0.14.",
+        bail!(
+            "patchelf {} found. auditwheel repair requires patchelf >= 0.14.",
             version
         );
     }