-
-
Notifications
You must be signed in to change notification settings - Fork 275
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
propagate abiflags to wheel name on Windows (#2325)
xref pydantic/jiter#172 (comment) At the moment the windows builds are hard coded to use the `none` abi tag (unless they are abi3). I think this is probably technically incorrect, though in practice has worked fine historically because there was only one build on Windows... until 3.13t has come along with free-threading as a second option :) It's important that we do emit proper abi tags (e.g. `cp313`, `cp313t`) because otherwise the two 3.13 wheels end up with the same name and can't be uploaded to PyPI. I think I also saw some install failures on `jiter` CI where a Python 3.13 build ended up installing the other build's wheel (I think `pip` detected an incorrect lib name and rejected it). I suspect I might need to fix some tests...
- Loading branch information
1 parent
4e61f3b
commit d7f11c9
Showing
2 changed files
with
27 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters