Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting a package's source does not preserve workspace's resolver #1570

Closed
1 of 2 tasks
epage opened this issue Apr 19, 2023 · 0 comments · Fixed by #1577
Closed
1 of 2 tasks

Extracting a package's source does not preserve workspace's resolver #1570

epage opened this issue Apr 19, 2023 · 0 comments · Fixed by #1577
Labels
bug Something isn't working sdist Source distribution

Comments

@epage
Copy link

epage commented Apr 19, 2023

Bug Description

When pulling out a project's source to build it independent of its workspace, it should pull along the resolver field but isn't.

note: cargo originally didn't do this but was later updated to do this (rust-lang/cargo#10911, rust-lang/cargo#10961).

note that this will only affect things if the lockfile needs to be generated.

Your maturin version (maturin --version)

0.14.17

Your Python version (python -V)

Python 3.10.6

Your pip version (pip -V)

pip 22.0.2

What bindings you're using

bin

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  1. Download source
  2. See no resolver set in typos-1.14.7/rust_src/typos-cli/Cargo.toml
  3. See resolver is set in https://github.com/crate-ci/typos/blob/master/Cargo.toml#L6
@epage epage added the bug Something isn't working label Apr 19, 2023
@messense messense added the sdist Source distribution label Apr 19, 2023
This was referenced Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdist Source distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants