-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for implicit namespace packages #1605
Comments
After further investigation users who need namespace packages can still use the older "pkgutil" trick kf really needed:
And so while support for implicit namespaces might be nice, its definitely not required for general namespace package usage |
This is duplicate of #811 |
Ok, will close the PR...so the answer really is to just switch to setuptools-rust ? The idea of using the init.py is problematic due to some downstream tools repackaging python packages in to debian flows (that complain about the init.py being there in multiple packages) |
i'll leave the final decision on this to @messense since he's way more active than me nowadays |
+1 for this. If the sole reason for not supporting implicit namespace is for linting agaist an opinionated best practice, can we change that to a warning instead of error? |
There is a check for requiring an
__init__.py
file in the levels of the python source directory. Can we get that check removed so that maturin can be used as part of packages implementing implicit namespaces ? PEP420maturin/src/project_layout.rs
Line 384 in e378ddd
The text was updated successfully, but these errors were encountered: