Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run option to maturin-publish command #377

Closed
MarTango opened this issue Nov 4, 2020 · 4 comments
Closed

Add --dry-run option to maturin-publish command #377

MarTango opened this issue Nov 4, 2020 · 4 comments

Comments

@MarTango
Copy link
Contributor

MarTango commented Nov 4, 2020

Similar to poetry's publish command, I think it would be cool if a --dry-run option was added which performed all steps except actually uploading build artifacts.

@ChillFish8
Copy link

Correct me if im wrong but isnt that the whole purpose of maturing develop [options]

@MarTango
Copy link
Contributor Author

MarTango commented Nov 9, 2020

I'd say that the closest command to this would be maturin build. publish takes the wheels and uploads to a python package repository. I created this issue because I was trying to figure out how to publish to a private package repository and didn't want to actually push anything.

In the end the issue I was coming across was due to the server not supporting the format that maturin publishes in, so a --dry-run option wouldn't have actually been helpful.

I'll leave this issue and a developer who's worked on the publish command can determine whether this would be a useful feature or not.

@konstin
Copy link
Member

konstin commented Nov 10, 2020

I fear there isn't much maturin can do here. publish essentially calls build, gets the credentials and then makes one http request per file to upload. The upload api doesn't have a feature to tell the server to validate the upload without actually publishing it.

@konstin konstin closed this as completed Nov 10, 2020
@programmerjake
Copy link
Contributor

Somewhat related: pypi/warehouse#726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants