Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow uniffi bin bindings #1353

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Disallow uniffi bin bindings #1353

merged 1 commit into from
Dec 13, 2022

Conversation

messense
Copy link
Member

It doesn't make sense, only pyo3 and rust-cpython bindings support both extension module and bin

It doesn't make sense, only `pyo3` and `rust-cpython` bindings
support both extension module and bin
@messense messense added bindings/bin bin bindings bindings/uniffi uniffi bindings labels Dec 13, 2022
@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 26abb90
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63981f7483cac20009527593
😎 Deploy Preview https://deploy-preview-1353--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense merged commit d5241d1 into PyO3:main Dec 13, 2022
@messense messense deleted the no-uniffi-bin branch December 13, 2022 07:29
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Dec 22, 2022
https://build.opensuse.org/request/show/1044089
by user mia + dimstar_suse
- Update to v0.14.7:
  * Update uniffi_bindgen to 0.22.0
    gh#PyO3/maturin#1359
  * Add workspace lock file to sdist as a fallback
    gh#PyO3/maturin#1362
- Changes in v0.14.6:
  * Allow Rust crate to be placed outside of the directory
    containing pyproject.toml
    gh#PyO3/maturin#1347
  * Disallow uniffi bin bindings
    gh#PyO3/maturin#1353
  * Update bundled Python sysconfigs for Linux and macOS
    gh#PyO3/maturin#1355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/bin bin bindings bindings/uniffi uniffi bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant