-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cargo-xwin to unify rustls versions #2222
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
plz merge, cross-compiling to windows doesn't work currently |
@messense xwin no longer uses ureq due to this issue: Jake-Shadle/xwin#141 |
It's unlikely we will upgrade to a xwin version that uses reqwest, there is no point in pulling in two http client library in maturin, and we'd like to avoid |
So cross-compilation for Windows will never work in maturin? |
Honestly I'm not sure what was your issue with it, it's working fine for me, Jake-Shadle/xwin#141 is a flaky issue, it's not happening all the time, in fact it never occurred locally on my dev machine. |
It is happening for me all the time and same for others as seen by my issue reactions. |
Then please consider investing some time to help debugging the root cause of the issue. |
d70525d
to
4483feb
Compare
a4d34a1
to
bf72801
Compare
bf72801
to
176c859
Compare
Fixes #1671
Currently
cargo install --locked
pulls in a yanked dependency, and the defaultcargo install
breaks due to fragility ofureq
's API. Either way it doesn't look good.