Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cargo-xwin to unify rustls versions #2222

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

kornelski
Copy link
Contributor

Fixes #1671

Currently cargo install --locked pulls in a yanked dependency, and the default cargo install breaks due to fragility of ureq's API. Either way it doesn't look good.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eedc9fc
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/66e9bc29aac37d000872a296
😎 Deploy Preview https://deploy-preview-2222--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sentialx
Copy link

sentialx commented Oct 6, 2024

plz merge, cross-compiling to windows doesn't work currently

@messense
Copy link
Member

messense commented Oct 16, 2024

plz merge, cross-compiling to windows doesn't work currently

@sentialx we're still waiting for a new ureq 2.x release, consider asking ureq for a new release if you want to push this forward.

@sentialx
Copy link

sentialx commented Oct 16, 2024

@messense xwin no longer uses ureq due to this issue: Jake-Shadle/xwin#141
Disregard my previous comment, this PR won't fix the issue, but updating xwin to 0.6.6-rc.1 should.

@messense
Copy link
Member

messense commented Oct 16, 2024

It's unlikely we will upgrade to a xwin version that uses reqwest, there is no point in pulling in two http client library in maturin, and we'd like to avoid reqwest because it also pulls in the whole tokio stack which bloats maturin by a lot in terms of compilation time.

@sentialx
Copy link

So cross-compilation for Windows will never work in maturin?

@messense
Copy link
Member

Honestly I'm not sure what was your issue with it, it's working fine for me, Jake-Shadle/xwin#141 is a flaky issue, it's not happening all the time, in fact it never occurred locally on my dev machine.

@sentialx
Copy link

It is happening for me all the time and same for others as seen by my issue reactions.

@messense
Copy link
Member

It is happening for me all the time

Then please consider investing some time to help debugging the root cause of the issue.

@messense messense force-pushed the cargo-install-fix branch 2 times, most recently from a4d34a1 to bf72801 Compare November 30, 2024 03:32
@messense messense enabled auto-merge (rebase) November 30, 2024 04:08
@messense messense merged commit b39f8ca into PyO3:main Nov 30, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't cargo install maturin anymore
3 participants