Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PYTHON_SYS_EXECUTABLE #539

Closed
konstin opened this issue Jul 15, 2019 · 1 comment · Fixed by #1039
Closed

Rename PYTHON_SYS_EXECUTABLE #539

konstin opened this issue Jul 15, 2019 · 1 comment · Fixed by #1039
Labels
enhancement

Comments

@konstin
Copy link
Member

konstin commented Jul 15, 2019

We should rename PYTHON_SYS_EXECUTABLE to something more more understandable like PYO3_INTERPRETER. The new name is up for bikeshedding.

pyo3 should continue to support both the PYTHON_SYS_EXECUTABLE and the new variable for some time, and we need to migrate setuptools-rust and pyo3-pack.
@davidhewitt davidhewitt mentioned this issue Jul 13, 2020
Merged
@davidhewitt
Copy link
Member

Closed via #1039

@davidhewitt davidhewitt linked a pull request Aug 6, 2020 that will close this issue
Rename PYTHON_SYS_EXECUTABLE to PYO3_PYTHON #1039
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename PYTHON_SYS_EXECUTABLE to PYO3_PYTHON davidhewitt/pyo3
2 participants
@davidhewitt @konstin