Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Cow[u8] conversions into conversions::std::slice module #3799

Merged
merged 1 commit into from
Feb 5, 2024
Merged

move Cow[u8] conversions into conversions::std::slice module #3799

merged 1 commit into from
Feb 5, 2024

Conversation

davidhewitt
Copy link
Member

Just moving code around.

A follow-up to #3784 (comment)

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 5, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2024

CodSpeed Performance Report

Merging #3799 will improve performances by 20.41%

Comparing davidhewitt:move-cow (7281268) with main (c9c6f92)

Summary

⚡ 3 improvements
✅ 76 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:move-cow Change
⚡ mapping_from_dict 327.8 ns 272.2 ns +20.41%
⚡ not_a_list_via_downcast 242.8 ns 215 ns +12.92%
⚡ sequence_from_list 355.6 ns 300 ns +18.52%

@adamreichold adamreichold added this pull request to the merge queue Feb 5, 2024
Merged via the queue into PyO3:main with commit c995426 Feb 5, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @adamreichold