-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port Python::get_type
to Bound
API
#3846
Conversation
CodSpeed Performance ReportMerging #3846 will degrade performances by 10.2%Comparing Summary
Benchmarks breakdown
|
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall looks great! Got a suggestion for the FIXME...
tests/test_inheritance.rs
Outdated
|
||
// FIXME: Whats the new API to do this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're looking for Py::new
or Bound::new
, I guess we should deprecate PyCell::new
in favour of one of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice and easy! (And thanks for catching, I totally forget that i put that there)
I guess we should deprecate
PyCell::new
in favour of one of these.
That's a good idea, I'll look into that 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Part of #3684
This ports
Python::get_type
to theBound
API. I implemented this on a rebase of #3705 (with minor changes to adapt for changes since creation), so this should compile already. All the changes related to theget_type
conversion are in a separate commit. I'll mark this as draft and rebase this when #3705 lands.