Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing deprecation for PyDict::from_sequence #3884

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Feb 22, 2024

Part of #3684

This adds a missing deprecation warning for PyDict::from_sequence.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Feb 22, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this one! ❤️

@davidhewitt davidhewitt added this pull request to the merge queue Feb 22, 2024
Merged via the queue into PyO3:main with commit 8bd82da Feb 23, 2024
38 of 40 checks passed
@Icxolu Icxolu deleted the dict-from-sequence branch February 24, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants