port PyErr::from_type to Bound API
#3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
commented
Feb 22, 2024
| @@ -192,11 +207,11 @@ impl PyErr { | |||
| /// If `ty` does not inherit from `BaseException`, then a `TypeError` will be returned. | |||
| /// | |||
| /// If calling `ty` with `args` raises an exception, that exception will be returned. | |||
| pub fn from_type<A>(ty: &PyType, args: A) -> PyErr | |||
| pub fn from_type_bound<A>(ty: Bound<'_, PyType>, args: A) -> PyErr | |||
There was a problem hiding this comment.
Arguably this could also just take a Py<PyType>, but then we would need a different name I guess...
There was a problem hiding this comment.
Ugh, yes. How about new_with_type?
I'm also kinda ok with leaving this as-is; it's a bit easier to get a Bound<PyType> than a Py<PyType> (e.g. with PyAnyMethods::get_type(), or just .downcast_into())
There was a problem hiding this comment.
What do you prefer? I think its fine either way.
There was a problem hiding this comment.
For simplicity of migration let's just keep this as is, given there's no obvious answer.
63 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3684
This ports
PyErr::from_typeto the newBoundAPI.