Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.21.0-beta.0 #3944

Merged
merged 1 commit into from
Mar 10, 2024
Merged

release: 0.21.0-beta.0 #3944

merged 1 commit into from
Mar 10, 2024

Conversation

davidhewitt
Copy link
Member

Related to #3674

This is a beta release (finally 🎉) for PyO3 0.21. It contains one unreviewed commit, which is #3906 squashed. If that merges before I release this, I'll rebase first, otherwise I'll leave this as-is. Apart from that, this is just the usual version bump.

Given that this is a prerelease, I'm inclined to put this live this evening unless someone can give me a reason to wait longer! 🚀

I have a list of followups to complete after the beta release before final, related to some of the larger ecosystem projects:

  • I will update pydantic-core to the beta release. I have been testing for a long time in disable PyO3 "gil refs" feature pydantic/pydantic-core#1085, so I think this should be smooth going.
  • I guess we should proceed with the rust-numpy branch to confirm that it's viable to make this update.
  • It would be helpful if cryptography can explore updating, cc @alex
  • I will also try to reach out to the polars team to get their feedback on how this API change affects them.

I also think we have just a few deprecation warnings to finish implementing in #3684, which @Icxolu has been making great headway into and I'll try to join in when I can find a moment.

Thank you to everyone who has helped get us to this point, in particular:

(Sorry if you also contributed and I have missed your name, this has been a long project with quite a few inputs!)

I hope that we have lots of success making the ecosystem faster and safer with the upcoming releases!

@samuelcolvin
Copy link
Contributor

Amazing work @davidhewitt, thank you for all your work on this.

@ritchie46 maybe you would be interested from the Polaris POV?

@alex
Copy link
Contributor

alex commented Mar 10, 2024

@reaperhulk has taken a look for cryptography (based on main from a day or two ago) -- I believe the summary is:

  • ~20 warnings with the gil-refs feature enabled, almost all related to is_true. Easy to resolve.
  • Tests pass with those resolved.
  • Building with gil-refs disabled is approximately 90 gazillion warnings, and that's going to take some time :-)

But he can confirm.

@davidhewitt
Copy link
Member Author

davidhewitt commented Mar 10, 2024

Building with gil-refs disabled is approximately 90 gazillion warnings, and that's going to take some time :-)

And we've probably only implemented 90% of the deprecation warnings, so maybe we can hit 100 gazillion warnings with 0.21 final 🙃

@alex
Copy link
Contributor

alex commented Mar 10, 2024

:D The good news is that it should be possible for us to tackle them incrementally. Once 0.21.0 is out, we'll do an meta issue with each impacted file, and we'll just burn them down one by one.

@reaperhulk
Copy link

reaperhulk commented Mar 10, 2024

When I tested on Friday we had 354 warnings without gil-refs (after fixing the initial 18). Frankly that's less than I would have expected, although it sounds like we'll get a few more soon 😄

@davidhewitt
Copy link
Member Author

Great, CI looks happy, and the release is live! Thanks again everybody; I'll keep pressing ahead with polish & testing. Looking forward to baking the final release soon!

@davidhewitt davidhewitt added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit 67b1b35 Mar 10, 2024
45 checks passed
@davidhewitt davidhewitt deleted the release-0.21.0-beta.0 branch March 10, 2024 23:01
SigureMo added a commit to ShigureLab/docstring-parser that referenced this pull request Mar 11, 2024
@ritchie46
Copy link

ritchie46 commented Mar 20, 2024

@ritchie46 maybe you would be interested from the Polaris POV?

Yes, we are definitely interested. Once ready we will do the refactor and keep you posted. :) Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants